public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Linux: Support non-variadic calls to prctl (bug 29770)
Date: Thu, 10 Nov 2022 21:41:59 +0100	[thread overview]
Message-ID: <87o7ter17s.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOqC4+-ToyGzisYpuF0vPhK1dvi2uZDtiCQ2bv_OWHxP0w@mail.gmail.com> (H. J. Lu's message of "Thu, 10 Nov 2022 12:34:37 -0800")

* H. J. Lu:

>> diff --git a/sysdeps/mips/dl-machine-reject-phdr.h b/sysdeps/mips/dl-machine-reject-phdr.h
>> index 45b6bcaeac..7efd5fc92b 100644
>> --- a/sysdeps/mips/dl-machine-reject-phdr.h
>> +++ b/sysdeps/mips/dl-machine-reject-phdr.h
>> @@ -169,7 +169,7 @@ elf_machine_reject_phdr_p (const ElfW(Phdr) *phdr, unsigned int phnum,
>>    bool cannot_mode_switch = false;
>>
>>    /* Get the current hardware mode.  */
>> -  cur_mode = __prctl (PR_GET_FP_MODE);
>> +  cur_mode = __prctl (PR_GET_FP_MODE, 0, 0, 0, 0);
>
> Can it use INLINE_SYSCALL_CALL here?

Probably, <sysdep.h> should be included by this point.  I can't run this
code for testing, so I tried to make minimal changes.

Thanks,
Florian


      reply	other threads:[~2022-11-10 20:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10 16:07 Florian Weimer
2022-11-10 18:43 ` H.J. Lu
2022-11-10 19:18   ` Florian Weimer
2022-11-10 19:55     ` H.J. Lu
2022-11-10 20:08       ` Florian Weimer
2022-11-11 13:27         ` Szabolcs Nagy
2023-09-04 14:46           ` Florian Weimer
2023-09-04 16:37             ` Szabolcs Nagy
2022-11-10 20:34 ` H.J. Lu
2022-11-10 20:41   ` Florian Weimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7ter17s.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=hjl.tools@gmail.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).