From: Florian Weimer <fweimer@redhat.com>
To: DJ Delorie via Libc-alpha <libc-alpha@sourceware.org>
Cc: DJ Delorie <dj@redhat.com>
Subject: Re: [patch v1] malloc: set NON_MAIN_ARENA flag for reclaimed memalign chunk (BZ #30101)
Date: Tue, 04 Apr 2023 12:26:32 +0200 [thread overview]
Message-ID: <87pm8kgcyv.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <xnv8icwr6j.fsf@greed.delorie.com> (DJ Delorie via Libc-alpha's message of "Mon, 03 Apr 2023 18:12:52 -0400")
* DJ Delorie via Libc-alpha:
> From 61bd502ecac4d63f04c74bfc491ca675660d26b7 Mon Sep 17 00:00:00 2001
> From: DJ Delorie <dj@redhat.com>
> Date: Mon, 3 Apr 2023 17:33:03 -0400
> Subject: malloc: set NON_MAIN_ARENA flag for reclaimed memalign chunk (BZ #30101)
>
> Based on these comments in malloc.c:
>
> size field is or'ed with NON_MAIN_ARENA if the chunk was obtained
> from a non-main arena. This is only set immediately before handing
> the chunk to the user, if necessary.
>
> The NON_MAIN_ARENA flag is never set for unsorted chunks, so it
> does not have to be taken into account in size comparisons.
>
> When we pull a chunk off the unsorted list (or any list) we need to
> make sure that flag is set properly before returning the chunk.
>
> diff --git a/malloc/malloc.c b/malloc/malloc.c
> index 0315ac5d16..66e7ca57dd 100644
> --- a/malloc/malloc.c
> +++ b/malloc/malloc.c
> @@ -5147,6 +5147,8 @@ _int_memalign (mstate av, size_t alignment, size_t bytes)
> p = victim;
> m = chunk2mem (p);
> set_inuse (p);
> + if (av != &main_arena)
> + set_non_main_arena (p);
> }
> else
> {
The change looks reasonable.
Can we add a test for this? Maybe run the existing memalign tests on a
second thread as well?
Thanks,
Florian
next prev parent reply other threads:[~2023-04-04 10:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 22:12 DJ Delorie
2023-04-04 10:26 ` Florian Weimer [this message]
2023-04-04 17:54 ` Carlos O'Donell
2023-04-05 2:27 ` [patch v2] " DJ Delorie
2023-04-05 6:14 ` Carlos O'Donell
2023-04-05 17:23 ` DJ Delorie
2023-04-06 17:09 ` Florian Weimer
2023-04-12 4:00 ` [patch v3] " DJ Delorie
2023-04-12 13:11 ` Cristian Rodríguez
2023-04-12 16:46 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm8kgcyv.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).