public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: DJ Delorie via Libc-alpha <libc-alpha@sourceware.org>
Cc: "Carlos O'Donell" <carlos@redhat.com>,  DJ Delorie <dj@redhat.com>
Subject: Re: [patch v2] malloc: set NON_MAIN_ARENA flag for reclaimed memalign chunk (BZ #30101)
Date: Thu, 06 Apr 2023 19:09:17 +0200	[thread overview]
Message-ID: <87sfddkkea.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <xnpm8iw8d2.fsf@greed.delorie.com> (DJ Delorie via Libc-alpha's message of "Wed, 05 Apr 2023 13:23:53 -0400")

* DJ Delorie via Libc-alpha:

> "Carlos O'Donell" <carlos@redhat.com> writes:
>> On line 5209 we don't set NON_MAIN_ARENA bits in the call to set_head_size(p, nb);
>> e.g. set_head_size (p, nb | (av != &main_arena ? NON_MAIN_ARENA : 0));
>
> set_head_size doesn't change the AMP bits, they remain set from the
> previous setting.  If the flags are wrong at that point, they were not
> set somewhere else (i.e. the set() I'm adding in this patch).

Agreed.  Would it be possible to fix this regression soon-ish?

Thanks,
Florian


  reply	other threads:[~2023-04-06 17:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-03 22:12 [patch v1] " DJ Delorie
2023-04-04 10:26 ` Florian Weimer
2023-04-04 17:54 ` Carlos O'Donell
2023-04-05  2:27   ` [patch v2] " DJ Delorie
2023-04-05  6:14     ` Carlos O'Donell
2023-04-05 17:23       ` DJ Delorie
2023-04-06 17:09         ` Florian Weimer [this message]
2023-04-12  4:00     ` [patch v3] " DJ Delorie
2023-04-12 13:11       ` Cristian Rodríguez
2023-04-12 16:46         ` DJ Delorie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfddkkea.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=carlos@redhat.com \
    --cc=dj@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).