public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Fangrui Song via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] elf.h: Add ELFCOMPRESS_ZSTD
Date: Wed, 10 Aug 2022 09:46:20 +0200	[thread overview]
Message-ID: <87pmh8fsmr.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20220708233233.2554110-1-maskray@google.com> (Fangrui Song via Libc-alpha's message of "Fri, 8 Jul 2022 16:32:33 -0700")

* Fangrui Song via Libc-alpha:

> Link: https://sourceware.org/pipermail/gnu-gabi/2022q2/000498.html ("New ch_type value ELFCOMPRESS_ZSTD?")
> Link: https://groups.google.com/g/generic-abi/c/satyPkuMisk ("Add new ch_type value: ELFCOMPRESS_ZSTD")
>
> ---
>
> I wish that the macro definition can catch up the upcoming
> https://sourceware.org/glibc/wiki/Release/2.36 [1], so that
> projects can expect the value ELFCOMPRESS_ZSTD from elf.h.
> The projects may choose to define the macro themselves,
> but having the definition in an earlier release seems a good idea
> anyway, and it the glibc definition makes it clearer ELFCOMPRESS_ZSTD
> is standard and vendors can start adding support.
>
> [1]: https://sourceware.org/pipermail/libc-alpha/2022-July/140352.html
> ("Release of glibc 2.36 in 1 month! Please add blockers and desirable for release.")
>
> From https://groups.google.com/g/generic-abi/c/9OO5vhxb00Y ("Ongoing Maintenance of the gABI"),
> we should be able to define this once Cary agrees.
> ---
>  elf/elf.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/elf/elf.h b/elf/elf.h
> index 2b5c2c5fb6..f6ae2348a9 100644
> --- a/elf/elf.h
> +++ b/elf/elf.h
> @@ -505,6 +505,7 @@ typedef struct
>  
>  /* Legal values for ch_type (compression algorithm).  */
>  #define ELFCOMPRESS_ZLIB	1	   /* ZLIB/DEFLATE algorithm.  */
> +#define ELFCOMPRESS_ZSTD	2	   /* Zstandard algorithm.  */
>  #define ELFCOMPRESS_LOOS	0x60000000 /* Start of OS-specific.  */
>  #define ELFCOMPRESS_HIOS	0x6fffffff /* End of OS-specific.  */
>  #define ELFCOMPRESS_LOPROC	0x70000000 /* Start of processor-specific.  */

Could you repost this with the actual commit message you intend to use?

Thanks,
Florian


      parent reply	other threads:[~2022-08-10  7:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-08 23:32 Fangrui Song
2022-07-11  4:58 ` Florian Weimer
2022-07-18 14:01   ` Carlos O'Donell
2022-07-22 23:08     ` Fangrui Song
2022-07-26 20:23       ` Adhemerval Zanella Netto
2022-07-26 20:30         ` Fangrui Song
2022-07-29 15:44           ` Carlos O'Donell
2022-08-04 20:04             ` Fangrui Song
2022-08-10  7:09               ` Fangrui Song
2022-08-10  7:46 ` Florian Weimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmh8fsmr.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).