public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] <signal.h>: Make bsd_signal available with _GNU_SOURCE
Date: Thu, 08 Dec 2022 19:10:23 +0100	[thread overview]
Message-ID: <87r0x9hils.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <e044567c-aca8-c219-4383-3f0f93cd5205@linaro.org> (Adhemerval Zanella Netto's message of "Thu, 8 Dec 2022 14:11:19 -0300")

* Adhemerval Zanella Netto:

> On 28/11/22 07:36, Florian Weimer via Libc-alpha wrote:
>> The declaration does not conflict with anything.  This simplifies
>> porting older software to C99 compilers which do not support implicit
>> function declarations and which need -D_GNU_SOURCE for other function
>> declarations.  Using __USE_MISC does not seem appropriate here because
>> other systems (e.g., FreeBSD) do not declare bsd_signal.
>
> I am not sure about this, bsd_signal is a POSIX deprecated and I think
> old software should really move to sigaction or define the correct flags
> to explicit use it.

And I thought this was the least controversial patch. 8-/

If -D_GNU_SOURCE is not the superset of all functionalities, it gets
more difficult to obtain all function prototypes, as needed for building
with stricter C99 compilers.  Currently, with default GCC flags, this
builds anyway due to an implicit function declaration, and I'd like to
preserve this behavior with GCC 14.

What about adding a deprecation warning?

Thanks,
Florian


  reply	other threads:[~2022-12-08 18:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28 10:36 Florian Weimer
2022-12-08 17:11 ` Adhemerval Zanella Netto
2022-12-08 18:10   ` Florian Weimer [this message]
2022-12-08 18:23     ` Adhemerval Zanella Netto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0x9hils.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).