From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 0/4] Move libio lock single-thread optimization to generic libc-lock
Date: Thu, 14 Apr 2022 17:28:05 +0200 [thread overview]
Message-ID: <87r15zwupm.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <717d3eec-dbc0-d9e6-185f-a02541591c6c@linaro.org> (Adhemerval Zanella's message of "Thu, 14 Apr 2022 11:23:08 -0300")
* Adhemerval Zanella:
> On 12/04/2022 09:18, Florian Weimer wrote:
>> * Adhemerval Zanella via Libc-alpha:
>>
>>> This patchset removes some old unused code (_IO_lock_inexpensive
>>> and _IO_MTSAFE_IO), consolidate the stdio-lock.h and move the
>>> single-thread lock optimization to generic code instead of
>>> per-function usage.
>>>
>>> Adhemerval Zanella (4):
>>> libio: Assume _IO_lock_inexpensive
>>> libio: Assume _IO_MTSAFE_IO
>>> Consolidate stdio-lock.h
>>> Move libio lock single-thread optimization to generic libc-lock (BZ
>>> #27842)
>>
>> This series is still assigned to me in Patchwork. Is it still active?
>
> I think it would be a good micro-optimization and a code consolidation,
> although I am not sure if it still applies. If you think it would be
> a good addition I can work on rebase and send a new version.
I'm interested in the _IO_MTSAFE_IO consolidation, but the rest looks
useful as well. I think we have some places where we define stdio
locking macros differently for no apparent reason, that that's just
waiting to cause trouble.
Thanks,
Florian
prev parent reply other threads:[~2022-04-14 15:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 20:44 Adhemerval Zanella
2021-05-27 20:44 ` [PATCH 1/4] libio: Assume _IO_lock_inexpensive Adhemerval Zanella
2021-05-30 13:11 ` Florian Weimer
2021-05-27 20:44 ` [PATCH 2/4] libio: Assume _IO_MTSAFE_IO Adhemerval Zanella
2021-05-27 21:38 ` Andreas Schwab
2021-05-27 20:44 ` [PATCH 3/4] Consolidate stdio-lock.h Adhemerval Zanella
2021-05-27 20:44 ` [PATCH 4/4] Move libio lock single-thread optimization to generic libc-lock (BZ #27842) Adhemerval Zanella
2022-04-12 12:18 ` [PATCH 0/4] Move libio lock single-thread optimization to generic libc-lock Florian Weimer
2022-04-14 14:23 ` Adhemerval Zanella
2022-04-14 15:28 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r15zwupm.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).