From: Andreas Schwab <schwab@linux-m68k.org>
To: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Cc: Yang Yanchao <yangyanchao6@huawei.com>,
Florian Weimer <fweimer@redhat.com>,
linfeilong@huawei.com
Subject: Re: [PATCH v4] elf: fixes compile error when both enable -Werror and -DNDEBUG
Date: Wed, 13 Apr 2022 14:46:35 +0200 [thread overview]
Message-ID: <87r16140d0.fsf@igel.home> (raw)
In-Reply-To: <87tuax47bg.fsf@oldenburg.str.redhat.com> (Florian Weimer via Libc-alpha's message of "Wed, 13 Apr 2022 12:16:19 +0200")
On Apr 13 2022, Florian Weimer via Libc-alpha wrote:
> Personally I would prefer __attribute__ ((unused)) directly on the
> old_offset declaration. I think it's clearer.
Perhaps even wrapping it inside #ifndef NDEBUG, like this:
#ifndef NDEBUG
off64_t old_offset =
#endif
lseek64 (fd, extension_offset, SEEK_SET);
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
prev parent reply other threads:[~2022-04-13 12:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 9:47 Yang Yanchao
2022-04-13 10:16 ` Florian Weimer
2022-04-13 12:46 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r16140d0.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=linfeilong@huawei.com \
--cc=yangyanchao6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).