From: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
To: libc-alpha@sourceware.org,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>, amodra@gmail.com
Subject: Re: [PATCHv2] powerpc64: Implement TLS using PC-relative addressing
Date: Mon, 25 Jan 2021 12:20:01 -0300 [thread overview]
Message-ID: <87sg6p59i6.fsf@linux.ibm.com> (raw)
In-Reply-To: <20210122012931.1354527-1-tuliom@linux.ibm.com>
Tulio Magno Quites Machado Filho via Libc-alpha <libc-alpha@sourceware.org> writes:
> Changes since v1:
> - Dropped the workaround for early GCC 10 versions. We can't get this
> code to work without having the macro __PCREL__. The previous code
> was failing if -mcpu=power10 -mno-pcrel was used.
> - Fixed coding style issues (added space after #defined and removed
> unnecessary parenthesis).
>
> ---8<---
>
> As the TOC pointer becomes optional on POWER, TLS access has to be
> modified in order to use PC-relative addressing instead of depending on
> the TOC pointer availability.
>
> This patch also changes old TLS code to use the new syntax. It's a
> purely aesthetical change: the old code still works and the new syntax
> helps to move the argument setup instruction away from the call, which
> is not used in an inline assembly.
>
> Suggested-by: Alan Modra <amodra@gmail.com>
Adhemerval,
I've just realized I forgot to Cc you in this patch.
It's fixing test failures when building glibc using --with-cpu=power10.
May we merge it for 2.33?
--
Tulio Magno
next prev parent reply other threads:[~2021-01-25 15:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 19:55 [PATCH] " Tulio Magno Quites Machado Filho
2020-10-01 8:49 ` Florian Weimer
2020-10-01 11:15 ` Alan Modra
2020-10-01 9:01 ` Andreas Schwab
2021-01-22 1:29 ` [PATCHv2] " Tulio Magno Quites Machado Filho
2021-01-25 15:20 ` Tulio Magno Quites Machado Filho [this message]
2021-01-25 17:13 ` Adhemerval Zanella
2021-01-25 20:22 ` Tulio Magno Quites Machado Filho
2021-01-27 11:16 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg6p59i6.fsf@linux.ibm.com \
--to=tuliom@linux.ibm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=amodra@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).