From: Florian Weimer <fweimer@redhat.com>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] posix: Don't automatically fail if _LIBC_REENTRANT isn't defined.
Date: Wed, 23 Sep 2020 13:56:00 +0200 [thread overview]
Message-ID: <87sgb8r9kf.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <20200923105126.13566-1-efraim@flashner.co.il> (Efraim Flashner's message of "Wed, 23 Sep 2020 13:51:26 +0300")
* Efraim Flashner:
> diff --git a/sysdeps/posix/system.c b/sysdeps/posix/system.c
> index a03f478fc7..19d07d2581 100644
> --- a/sysdeps/posix/system.c
> +++ b/sysdeps/posix/system.c
> @@ -101,7 +101,7 @@ cancel_handler (void *arg)
> static int
> do_system (const char *line)
> {
> - int status = -1;
> + int status = 0;
> int ret;
> pid_t pid;
> struct sigaction sa;
I don't think this is correct. You are just hiding an error return from
posix_spawn, I think.
A test case (against unpatched glibc) would help to clarify what you are
looking for.
Thanks,
Florian
--
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill
prev parent reply other threads:[~2020-09-23 11:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 10:51 Efraim Flashner
2020-09-23 11:56 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgb8r9kf.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=efraim@flashner.co.il \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).