public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Bruno Haible <bruno@clisp.org>,
	 Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	 libc-alpha@sourceware.org,  Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: [PATCH v5] posix: Sync tempname with gnulib
Date: Wed, 17 Apr 2024 19:04:17 +0200	[thread overview]
Message-ID: <87ttjzgbu6.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <mvmwmow5a34.fsf@suse.de> (Andreas Schwab's message of "Wed, 17 Apr 2024 16:37:35 +0200")

* Andreas Schwab:

> On Apr 17 2024, Bruno Haible wrote:
>
>> Andreas Schwab wrote:
>>> > -              while (unfair_min <= v);
>>>                         v >= unfair_min
>>
>> Code written by Paul Eggert prefers use of the operators < and <=,
>> rather than > and >=. It's a matter of style. Such questions of style
>> are not worth introducing differences between gnulib and glibc.
>
> We cannot accept obfuscated code.  We have higher standards.

I also prefer to mention the fastest-changing variable first in
comparisons.

Thanks,
Florian


  reply	other threads:[~2024-04-17 17:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-10 12:20 Adhemerval Zanella
2024-04-10 14:30 ` Bruno Haible
2024-04-17 12:26 ` Andreas Schwab
2024-04-17 13:51   ` Bruno Haible
2024-04-17 14:37     ` Andreas Schwab
2024-04-17 17:04       ` Florian Weimer [this message]
2024-04-17 20:33       ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttjzgbu6.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=bruno@clisp.org \
    --cc=eggert@cs.ucla.edu \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).