Re: [PATCH v2] MIPS: Sync elf.h from binutils

[Florian Weimer <fweimer@redhat.com>]

* Ying Huang:

> +#define EF_MIPS_MACH		0x00FF0000 /* Machine variant if we know it.  This field was invented at Cygnus,
> +					      but it is hoped that other vendors will adopt it.  If some standard
> +					      is developed, this code should be changed to follow it. */
> +#define E_MIPS_MACH_3900	0x00810000 /* Cygnus is choosing values between 80 and 9F;
> +					      00 - 7F should be left for a future standard;
> +					      the rest are open. */

Surely after around 25 years, these comments can be more precise?

> +/* Object attribute tags.  */
> +enum
> +{
> +  /* 0-3 are generic.  */
> +
> +  /* Floating-point ABI used by this object file.  */
> +  Tag_GNU_MIPS_ABI_FP = 4,
> +
> +  /* MSA ABI used by this object file.  */
> +  Tag_GNU_MIPS_ABI_MSA = 8,
> +};
> +
> +/* Object attribute values.  */
> +enum
> +{
> +  /* Values defined for Tag_GNU_MIPS_ABI_MSA.  */
> +
> +  /* Not tagged or not using any ABIs affected by the differences.  */
> +  Val_GNU_MIPS_ABI_MSA_ANY = 0,
> +
> +  /* Using 128-bit MSA.  */
> +  Val_GNU_MIPS_ABI_MSA_128 = 1,
> +};

Any reason for using enum constants here, and not #define?  I understand
there is other MIPS precedent, but why continue in this direction?

Thanks,
Florian