From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Florian Weimer <fweimer@redhat.com>
Cc: Ying Huang <ying.huang@oss.cipunited.com>,
libc-alpha@sourceware.org, yunqiang.su@oss.cipunited.com
Subject: Re: [PATCH v2] MIPS: Sync elf.h from binutils
Date: Fri, 19 May 2023 12:21:29 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2305190550110.50034@angie.orcam.me.uk> (raw)
In-Reply-To: <87v8gs6a3l.fsf@oldenburg.str.redhat.com>
On Tue, 16 May 2023, Florian Weimer via Libc-alpha wrote:
> > +/* Object attribute values. */
> > +enum
> > +{
> > + /* Values defined for Tag_GNU_MIPS_ABI_MSA. */
> > +
> > + /* Not tagged or not using any ABIs affected by the differences. */
> > + Val_GNU_MIPS_ABI_MSA_ANY = 0,
> > +
> > + /* Using 128-bit MSA. */
> > + Val_GNU_MIPS_ABI_MSA_128 = 1,
> > +};
>
> Any reason for using enum constants here, and not #define? I understand
> there is other MIPS precedent, but why continue in this direction?
AFAICT all architectures use enumeration constants for object attributes,
with the exception of TI C6X which seems to have special requirements. I
don't know what the actual original rationale has been, but it does help a
lot with debugging.
Maciej
next prev parent reply other threads:[~2023-05-19 11:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 6:15 Ying Huang
2023-05-16 6:53 ` Florian Weimer
2023-05-19 11:21 ` Maciej W. Rozycki [this message]
2023-05-19 12:43 ` Gabriel Ravier
2023-05-16 9:12 Ying Huang
2023-06-01 9:17 ` [PATCH " Ying Huang
2023-06-01 9:21 ` Florian Weimer
2023-06-01 9:40 ` Ying Huang
2023-06-01 10:32 ` Florian Weimer
2023-06-01 10:46 ` 黄莺
2023-06-28 1:43 ` Ying Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2305190550110.50034@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=ying.huang@oss.cipunited.com \
--cc=yunqiang.su@oss.cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).