From: Andreas Schwab <schwab@linux-m68k.org>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Cc: John David Anglin <danglin@gcc.gnu.org>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH v3] hppa: Fix bind-now audit (BZ #28857)
Date: Mon, 07 Feb 2022 16:46:02 +0100 [thread overview]
Message-ID: <87v8xqvfwl.fsf@igel.home> (raw)
In-Reply-To: <20220207141511.668554-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Mon, 7 Feb 2022 11:15:11 -0300")
On Feb 07 2022, Adhemerval Zanella via Libc-alpha wrote:
> +/* Clear the plabel bit to get the actual address of the descriptor. */
> +#define DL_FIXUP_ADDR_VALUE(addr) \
> + (*(DL_FIXUP_VALUE_TYPE *) ((unsigned int) (addr) & ~2))
Why not uintptr_t?
> +#define DL_FIXUP_BINDNOW_RELOC(value, new_value, st_value) \
> + *(value) = *(DL_FIXUP_VALUE_TYPE *) ((unsigned int) (new_value) & ~2);
Likewise. Why is there a semicolon?
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2022-02-07 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 14:15 Adhemerval Zanella
2022-02-07 15:28 ` John David Anglin
2022-02-07 15:46 ` Andreas Schwab [this message]
2022-02-07 17:13 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8xqvfwl.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=adhemerval.zanella@linaro.org \
--cc=danglin@gcc.gnu.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).