From: Andreas Schwab <schwab@linux-m68k.org>
To: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Cc: Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH] elf: Assert range of ns argument in _dl_debug_initialize
Date: Mon, 28 Jun 2021 09:26:08 +0200 [thread overview]
Message-ID: <87v95y8n73.fsf@igel.home> (raw)
In-Reply-To: <87y2b04us6.fsf@oldenburg.str.redhat.com> (Florian Weimer via Libc-alpha's message of "Wed, 23 Jun 2021 14:42:17 +0200")
On Jun 23 2021, Florian Weimer via Libc-alpha wrote:
> @@ -49,7 +51,11 @@ _dl_debug_initialize (ElfW(Addr) ldbase, Lmid_t ns)
> if (ns == LM_ID_BASE)
> r = &_r_debug;
> else
> - r = &GL(dl_ns)[ns]._ns_debug;
> + {
> + assert (ns >= 0);
> + assert (ns < array_length (GL (dl_ns)));
The asserts can be combined.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
prev parent reply other threads:[~2021-06-28 7:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 12:42 Florian Weimer
2021-06-27 22:15 ` Carlos O'Donell
2021-06-27 22:51 ` Florian Weimer
2021-06-28 2:15 ` Carlos O'Donell
2021-06-28 8:31 ` Florian Weimer
2021-06-28 7:26 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v95y8n73.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).