public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* Allow _Qp_fgt in sparc64 localplt.data
@ 2022-12-13 16:55 Joseph Myers
  2022-12-13 21:20 ` Florian Weimer
  0 siblings, 1 reply; 2+ messages in thread
From: Joseph Myers @ 2022-12-13 16:55 UTC (permalink / raw)
  To: libc-alpha

A recent GCC change resulted in localplt test failures on sparc64
because of references to _Qp_fgt.  This is analogous to all the other
floating-point symbols allowed in localplt.data, so it seems
appropriate to allow this one as well.

Tested with build-many-glibcs.py for sparc64-linux-gnu (GCC mainline),
where it fixes the test failure.

diff --git a/sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data b/sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data
index 12520b1586..15c0f8ccf7 100644
--- a/sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data
+++ b/sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data
@@ -3,6 +3,7 @@ libc.so: _Qp_cmp ?
 libc.so: _Qp_div ?
 libc.so: _Qp_feq ?
 libc.so: _Qp_fge ?
+libc.so: _Qp_fgt ?
 libc.so: _Qp_fle ?
 libc.so: _Qp_flt ?
 libc.so: _Qp_fne ?

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Allow _Qp_fgt in sparc64 localplt.data
  2022-12-13 16:55 Allow _Qp_fgt in sparc64 localplt.data Joseph Myers
@ 2022-12-13 21:20 ` Florian Weimer
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Weimer @ 2022-12-13 21:20 UTC (permalink / raw)
  To: Joseph Myers; +Cc: libc-alpha

* Joseph Myers:

> A recent GCC change resulted in localplt test failures on sparc64
> because of references to _Qp_fgt.  This is analogous to all the other
> floating-point symbols allowed in localplt.data, so it seems
> appropriate to allow this one as well.
>
> Tested with build-many-glibcs.py for sparc64-linux-gnu (GCC mainline),
> where it fixes the test failure.
>
> diff --git a/sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data b/sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data
> index 12520b1586..15c0f8ccf7 100644
> --- a/sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data
> +++ b/sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data
> @@ -3,6 +3,7 @@ libc.so: _Qp_cmp ?
>  libc.so: _Qp_div ?
>  libc.so: _Qp_feq ?
>  libc.so: _Qp_fge ?
> +libc.so: _Qp_fgt ?
>  libc.so: _Qp_fle ?
>  libc.so: _Qp_flt ?
>  libc.so: _Qp_fne ?

Seems reasonable, thanks.

Florian


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-12-13 21:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-13 16:55 Allow _Qp_fgt in sparc64 localplt.data Joseph Myers
2022-12-13 21:20 ` Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).