From: Andreas Schwab <schwab@linux-m68k.org>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Cc: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
Yu Chien Peter Lin <peterlin@andestech.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH] malloc: Do not clobber errno on __getrandom_nocancel (BZ#29624)
Date: Thu, 29 Sep 2022 19:31:11 +0200 [thread overview]
Message-ID: <87wn9mozog.fsf@igel.home> (raw)
In-Reply-To: <20220929164510.3454281-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Thu, 29 Sep 2022 13:45:10 -0300")
On Sep 29 2022, Adhemerval Zanella via Libc-alpha wrote:
> @@ -51,7 +51,7 @@ __arc4random_buf (void *p, size_t n)
> n -= l;
> continue; /* Interrupted by a signal; keep going. */
> }
> - else if (l < 0 && errno == ENOSYS)
> + else if (l < 0 && l == -ENOSYS)
This is a redundant condition.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2022-09-29 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 16:45 Adhemerval Zanella
2022-09-29 17:31 ` Andreas Schwab [this message]
2022-09-29 17:46 ` Yann Droneaud
2022-09-29 17:49 ` Adhemerval Zanella Netto
2022-09-29 17:52 ` Wilco Dijkstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn9mozog.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=Wilco.Dijkstra@arm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=peterlin@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).