public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Cc: Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH] manual: Document the dlinfo function
Date: Thu, 14 Apr 2022 17:27:28 +0200	[thread overview]
Message-ID: <87y207y9b3.fsf@igel.home> (raw)
In-Reply-To: <87zgknwvvh.fsf@oldenburg.str.redhat.com> (Florian Weimer via Libc-alpha's message of "Thu, 14 Apr 2022 17:02:58 +0200")

On Apr 14 2022, Florian Weimer via Libc-alpha wrote:

> +@item RTLD_DI_SERINFO
> +@item RTLD_DI_SERINFOSIZE

The second @item needs to be @itemx.

> +These requests can be used to obtain search path information for
> +@var{handle}.  For both requests, @var{arg} must point to a
> +@code{Dl_serinfo} object.  The @code{RTLD_DI_SERINFOSIZE} request must
> +be made first; it updates the @code{@var{arg}->dls_size} and
> +@code{@var{arg}->dls_cnt} members.

This is misleading since arg is a void pointer.  Perhaps just refer to
the members by their name:

  ... it updates the @code{dls_size} and @code{dls_cnt} members of the
  @code{Dl_serinfo} object.

> +This interface is prone to buffer overflows in multi-threaded because

+processes

> +@item RTLD_DI_TLS_DATA
> +This request writes the address of the TLS block (in the current thread)
> +for the shared object identified by @var{handle} to a @code{void *}
> +object at address @var{arg} (that is, @var{arg} must be of type
> +@code{void **}).

This description is weirdly different from the others wrt. how @var{arg}
is described.  I think how the other places describe it is better.

> +The reminder of this section documents the @code{_dl_find_object}

remainder

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

      reply	other threads:[~2022-04-14 15:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14 15:02 Florian Weimer
2022-04-14 15:27 ` Andreas Schwab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y207y9b3.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).