From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 04/11] nptl: Move sem_close, sem_open into libc
Date: Wed, 05 May 2021 17:30:51 +0200 [thread overview]
Message-ID: <87y2ctdwpg.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <2901c489-d949-bade-cb81-0ef35cdf261a@linaro.org> (Adhemerval Zanella's message of "Wed, 5 May 2021 11:33:52 -0300")
* Adhemerval Zanella:
> On 03/05/2021 10:51, Florian Weimer via Libc-alpha wrote:
>> The symbols were moved using move-symbol-to-libc.py.
>>
>> Both functions are moved at the same time because they depend
>> on internal functions in sysdeps/pthread/sem_routines.c, which
>> are moved in this commit as well. Additional hidden prototypes
>> are required to avoid check-localplt failures.
>
> LGTM, with some small nits below.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Thanks, I've applied these suggestions.
Florian
next prev parent reply other threads:[~2021-05-05 15:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 13:51 [PATCH 00/11] nptl: Move semaphore functions " Florian Weimer
2021-05-03 13:51 ` [PATCH 01/11] nptl: Move pthread_testcancel " Florian Weimer
2021-05-05 14:16 ` Adhemerval Zanella
2021-05-03 13:51 ` [PATCH 02/11] nptl: Consolidate aysnc cancel enable/disable implementation in libc Florian Weimer
2021-05-05 14:21 ` Adhemerval Zanella
2021-05-03 13:51 ` [PATCH 03/11] nptl: Move sem_clockwait into libc Florian Weimer
2021-05-05 14:30 ` Adhemerval Zanella
2021-05-03 13:51 ` [PATCH 04/11] nptl: Move sem_close, sem_open " Florian Weimer
2021-05-05 14:33 ` Adhemerval Zanella
2021-05-05 15:30 ` Florian Weimer [this message]
2021-05-03 13:51 ` [PATCH 05/11] nptl: Move sem_destroy " Florian Weimer
2021-05-05 14:35 ` Adhemerval Zanella
2021-05-03 13:51 ` [PATCH 06/11] nptl: Move sem_getvalue " Florian Weimer
2021-05-05 14:35 ` Adhemerval Zanella
2021-05-03 13:52 ` [PATCH 07/11] nptl: Move sem_init " Florian Weimer
2021-05-05 14:36 ` Adhemerval Zanella
2021-05-03 13:52 ` [PATCH 08/11] nptl: Move sem_post " Florian Weimer
2021-05-05 14:36 ` Adhemerval Zanella
2021-05-03 13:52 ` [PATCH 09/11] nptl: Move sem_timedwait " Florian Weimer
2021-05-05 14:37 ` Adhemerval Zanella
2021-05-03 13:52 ` [PATCH 10/11] nptl: Move sem_unlink " Florian Weimer
2021-05-05 14:37 ` Adhemerval Zanella
2021-05-03 13:52 ` [PATCH 11/11] nptl: Move sem_trywait, sem_wait " Florian Weimer
2021-05-05 14:38 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2ctdwpg.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).