From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 02/13] resolv: Add tst-resolv-aliases
Date: Wed, 24 Aug 2022 15:30:19 +0200 [thread overview]
Message-ID: <87zgft6a6s.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <9dc19001-b490-07f6-e18d-717b08968ec1@gotplt.org> (Siddhesh Poyarekar's message of "Thu, 18 Aug 2022 12:36:49 -0400")
* Siddhesh Poyarekar:
>> +static void
>> +check_cnames_failure (int af, bool do_search, int cnames, int addresses)
>> +{
>> + char *qname = make_qname (do_search, cnames, addresses);
>> +
>> + struct hostent *e;
>> + if (af == AF_UNSPEC)
>> + e = gethostbyname (qname);
>> + else
>> + e = gethostbyname2 (qname, af);
>> +
>> + if (addresses == 0)
>> + check_hostent (qname, e, "error: NO_RECOVERY\n"); /* Should be NO_DATA. */
>
> Could the response be rewritten so that the check could be for NO_DATA
> here? Or have I misunderstood the comment?
I forgot to respond to this: The comment is likely wrong, I will drop
it.
Thanks,
Florian
next prev parent reply other threads:[~2022-08-24 13:30 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 9:30 [PATCH 00/13] nss_dns: Fix handling of non-host CNAMEs (bug 12154) Florian Weimer
2022-08-10 9:30 ` [PATCH 01/13] resolv: Add tst-resolv-byaddr for testing reverse lookup Florian Weimer
2022-08-18 15:26 ` Siddhesh Poyarekar
2022-08-10 9:30 ` [PATCH 02/13] resolv: Add tst-resolv-aliases Florian Weimer
2022-08-18 16:36 ` Siddhesh Poyarekar
2022-08-19 14:20 ` Florian Weimer
2022-08-19 14:27 ` Siddhesh Poyarekar
2022-08-19 14:54 ` Florian Weimer
2022-08-24 13:30 ` Florian Weimer [this message]
2022-08-10 9:30 ` [PATCH 03/13] resolv: Add internal __res_binary_hnok function Florian Weimer
2022-08-18 16:40 ` Siddhesh Poyarekar
2022-08-10 9:30 ` [PATCH 04/13] resolv: Add the __ns_samebinaryname function Florian Weimer
2022-08-18 16:46 ` Siddhesh Poyarekar
2022-08-10 9:30 ` [PATCH 05/13] resolv: Add internal __ns_name_length_uncompressed function Florian Weimer
2022-08-18 17:23 ` Siddhesh Poyarekar
2022-08-10 9:30 ` [PATCH 06/13] resolv: Add DNS packet parsing helpers geared towards wire format Florian Weimer
2022-08-18 18:57 ` Siddhesh Poyarekar
2022-08-19 14:59 ` Florian Weimer
2022-08-19 15:13 ` Siddhesh Poyarekar
2022-08-22 15:59 ` Siddhesh Poyarekar
2022-08-10 9:30 ` [PATCH 07/13] nss_dns: Split getanswer_ptr from getanswer_r Florian Weimer
2022-08-22 16:18 ` Siddhesh Poyarekar
2022-08-10 9:30 ` [PATCH 08/13] nss_dns: Rewrite _nss_dns_gethostbyaddr2_r and getanswer_ptr Florian Weimer
2022-08-22 21:59 ` Siddhesh Poyarekar
2022-08-10 9:30 ` [PATCH 09/13] nss_dns: Remove remnants of IPv6 address mapping Florian Weimer
2022-08-22 22:05 ` Siddhesh Poyarekar
2022-08-10 9:30 ` [PATCH 10/13] nss_dns: Rewrite getanswer_r to match getanswer_ptr (bug 12154, bug 29305) Florian Weimer
2022-08-22 22:20 ` Siddhesh Poyarekar
2022-08-10 9:31 ` [PATCH 11/13] nss_dns: In gaih_getanswer_slice, skip strange aliases (bug 12154) Florian Weimer
2022-08-23 12:23 ` Siddhesh Poyarekar
2022-08-10 9:31 ` [PATCH 12/13] resolv: Add new tst-resolv-invalid-cname Florian Weimer
2022-08-23 12:32 ` Siddhesh Poyarekar
2022-08-10 9:31 ` [PATCH 13/13] nss_dns: Rewrite _nss_dns_gethostbyname4_r using current interfaces Florian Weimer
2022-08-23 12:49 ` Siddhesh Poyarekar
2022-08-24 12:25 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgft6a6s.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).