public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: libc-alpha@sourceware.org
Subject: [PATCH 00/13] nss_dns: Fix handling of non-host CNAMEs (bug 12154)
Date: Wed, 10 Aug 2022 11:30:13 +0200	[thread overview]
Message-ID: <cover.1660123636.git.fweimer@redhat.com> (raw)

This series is my last attempt at fixing bug 12154.  The bug is that
some sites have names like *.wildcard.example.org in their CNAME chains,
and we fail lookup completely instead of suppressing that invalid host
names.

The changes are more involved than I would have liked, but each time I
think I have a simple fix, I end up rewriting the DNS parsers.

Tested on i686-linux-gnu and x86_64-linux-gnu.

Thanks,
Florian

Florian Weimer (13):
  resolv: Add tst-resolv-byaddr for testing reverse lookup
  resolv: Add tst-resolv-aliases
  resolv: Add internal __res_binary_hnok function
  resolv: Add the __ns_samebinaryname function
  resolv: Add internal __ns_name_length_uncompressed function
  resolv: Add DNS packet parsing helpers geared towards wire format
  nss_dns: Split getanswer_ptr from getanswer_r
  nss_dns: Rewrite _nss_dns_gethostbyaddr2_r and getanswer_ptr
  nss_dns: Remove remnants of IPv6 address mapping
  nss_dns: Rewrite getanswer_r to match getanswer_ptr (bug 12154, bug
    29305)
  nss_dns: In gaih_getanswer_slice, skip strange aliases (bug 12154)
  resolv: Add new tst-resolv-invalid-cname
  nss_dns: Rewrite _nss_dns_gethostbyname4_r using current interfaces

 include/arpa/nameser.h                   |  106 ++
 include/resolv.h                         |    3 +
 resolv/Makefile                          |   23 +
 resolv/README                            |    3 -
 resolv/mapv4v6addr.h                     |   69 --
 resolv/mapv4v6hostent.h                  |   84 --
 resolv/ns_name_length_uncompressed.c     |   72 ++
 resolv/ns_rr_cursor_init.c               |   62 ++
 resolv/ns_rr_cursor_next.c               |   74 ++
 resolv/ns_samebinaryname.c               |   55 +
 resolv/nss_dns/dns-host.c                | 1184 +++++++++-------------
 resolv/res-name-checking.c               |   14 +-
 resolv/tst-ns_name_length_uncompressed.c |  135 +++
 resolv/tst-ns_rr_cursor.c                |  227 +++++
 resolv/tst-ns_samebinaryname.c           |   62 ++
 resolv/tst-resolv-aliases.c              |  267 +++++
 resolv/tst-resolv-byaddr.c               |  339 +++++++
 resolv/tst-resolv-invalid-cname.c        |  406 ++++++++
 18 files changed, 2303 insertions(+), 882 deletions(-)
 delete mode 100644 resolv/mapv4v6addr.h
 delete mode 100644 resolv/mapv4v6hostent.h
 create mode 100644 resolv/ns_name_length_uncompressed.c
 create mode 100644 resolv/ns_rr_cursor_init.c
 create mode 100644 resolv/ns_rr_cursor_next.c
 create mode 100644 resolv/ns_samebinaryname.c
 create mode 100644 resolv/tst-ns_name_length_uncompressed.c
 create mode 100644 resolv/tst-ns_rr_cursor.c
 create mode 100644 resolv/tst-ns_samebinaryname.c
 create mode 100644 resolv/tst-resolv-aliases.c
 create mode 100644 resolv/tst-resolv-byaddr.c
 create mode 100644 resolv/tst-resolv-invalid-cname.c


base-commit: 2ed26bca997a8fc898f4cb94484abaee2f307311
-- 
2.37.1


             reply	other threads:[~2022-08-10  9:30 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-10  9:30 Florian Weimer [this message]
2022-08-10  9:30 ` [PATCH 01/13] resolv: Add tst-resolv-byaddr for testing reverse lookup Florian Weimer
2022-08-18 15:26   ` Siddhesh Poyarekar
2022-08-10  9:30 ` [PATCH 02/13] resolv: Add tst-resolv-aliases Florian Weimer
2022-08-18 16:36   ` Siddhesh Poyarekar
2022-08-19 14:20     ` Florian Weimer
2022-08-19 14:27       ` Siddhesh Poyarekar
2022-08-19 14:54         ` Florian Weimer
2022-08-24 13:30     ` Florian Weimer
2022-08-10  9:30 ` [PATCH 03/13] resolv: Add internal __res_binary_hnok function Florian Weimer
2022-08-18 16:40   ` Siddhesh Poyarekar
2022-08-10  9:30 ` [PATCH 04/13] resolv: Add the __ns_samebinaryname function Florian Weimer
2022-08-18 16:46   ` Siddhesh Poyarekar
2022-08-10  9:30 ` [PATCH 05/13] resolv: Add internal __ns_name_length_uncompressed function Florian Weimer
2022-08-18 17:23   ` Siddhesh Poyarekar
2022-08-10  9:30 ` [PATCH 06/13] resolv: Add DNS packet parsing helpers geared towards wire format Florian Weimer
2022-08-18 18:57   ` Siddhesh Poyarekar
2022-08-19 14:59     ` Florian Weimer
2022-08-19 15:13       ` Siddhesh Poyarekar
2022-08-22 15:59   ` Siddhesh Poyarekar
2022-08-10  9:30 ` [PATCH 07/13] nss_dns: Split getanswer_ptr from getanswer_r Florian Weimer
2022-08-22 16:18   ` Siddhesh Poyarekar
2022-08-10  9:30 ` [PATCH 08/13] nss_dns: Rewrite _nss_dns_gethostbyaddr2_r and getanswer_ptr Florian Weimer
2022-08-22 21:59   ` Siddhesh Poyarekar
2022-08-10  9:30 ` [PATCH 09/13] nss_dns: Remove remnants of IPv6 address mapping Florian Weimer
2022-08-22 22:05   ` Siddhesh Poyarekar
2022-08-10  9:30 ` [PATCH 10/13] nss_dns: Rewrite getanswer_r to match getanswer_ptr (bug 12154, bug 29305) Florian Weimer
2022-08-22 22:20   ` Siddhesh Poyarekar
2022-08-10  9:31 ` [PATCH 11/13] nss_dns: In gaih_getanswer_slice, skip strange aliases (bug 12154) Florian Weimer
2022-08-23 12:23   ` Siddhesh Poyarekar
2022-08-10  9:31 ` [PATCH 12/13] resolv: Add new tst-resolv-invalid-cname Florian Weimer
2022-08-23 12:32   ` Siddhesh Poyarekar
2022-08-10  9:31 ` [PATCH 13/13] nss_dns: Rewrite _nss_dns_gethostbyname4_r using current interfaces Florian Weimer
2022-08-23 12:49   ` Siddhesh Poyarekar
2022-08-24 12:25     ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1660123636.git.fweimer@redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).