public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Fangrui Song via Libc-alpha <libc-alpha@sourceware.org>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	 Alan Modra <amodra@gmail.com>,
	 Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>,
	 Fangrui Song <maskray@google.com>
Subject: Re: [PATCH v2] elf: Replace PI_STATIC_AND_HIDDEN with opposite HIDDEN_VAR_NEEDS_DYNAMIC_RELOC
Date: Tue, 26 Apr 2022 08:47:38 +0200	[thread overview]
Message-ID: <87zgk8l4s5.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20220425181652.2627618-1-maskray@google.com> (Fangrui Song via Libc-alpha's message of "Mon, 25 Apr 2022 11:16:52 -0700")

* Fangrui Song via Libc-alpha:

> PI_STATIC_AND_HIDDEN indicates whether accesses to internal linkage
> variables and hidden visibility variables in a shared object (ld.so)
> need dynamic relocations (usually R_*_RELATIVE). PI (position
> independent) in the macro name is a misnomer: a code sequence using GOT
> is typically position-independent as well, but using dynamic relocations
> does not meet the requirement.
>
> Not defining PI_STATIC_AND_HIDDEN is legacy and we expect that all new
> ports will define PI_STATIC_AND_HIDDEN. Current ports defining
> PI_STATIC_AND_HIDDEN are more than the opposite. Change the configure
> default.
>
> No functional change.
>
> Note: HIDDEN_VAR_NEEDS_DYNAMIC_RELOC will be removed when Alan Modra's
> powerpc64 static-pie work
> (https://sourceware.org/pipermail/libc-alpha/2022-April/137987.html)
> lands.
>
> Changes from v1:
> * Correctly regenerate sysdeps/m68k/configure

I can confirm that this still builds all targets.

Thanks,
Florian


  reply	other threads:[~2022-04-26  6:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25 18:16 Fangrui Song
2022-04-26  6:47 ` Florian Weimer [this message]
2022-04-26 11:46 ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgk8l4s5.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=amodra@gmail.com \
    --cc=libc-alpha@sourceware.org \
    --cc=maskray@google.com \
    --cc=tuliom@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).