Re: [glibc] stdlib: Sort tests in Makefile

Re: [glibc] stdlib: Sort tests in Makefile

[Florian Weimer]

* Siddhesh Poyarekar via Glibc-cvs:

> +tests		:=  bug-fmtmsg1 \
> +		    bug-getcontext \

> +		    tst-width \
> +		    tst-width-stdint \
> +		    tst-xpg-basename

Please use two-space indentation like elsewhere, and add the trailing
“# tests”.  Thanks.

Florian

[PATCH] stdlib: Fix formatting of tests list in Makefile

[Siddhesh Poyarekar]

Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
---
 stdlib/Makefile | 152 ++++++++++++++++++++++++------------------------
 1 file changed, 77 insertions(+), 75 deletions(-)

diff --git a/stdlib/Makefile b/stdlib/Makefile
index 52e4d8cf19..1e81f98fac 100644
--- a/stdlib/Makefile
+++ b/stdlib/Makefile
@@ -65,81 +65,83 @@ aux =	grouping groupingwc tens_in_limb
 static-only-routines = atexit at_quick_exit
 
 test-srcs	:= tst-fmtmsg
-tests		:=  bug-fmtmsg1 \
-		    bug-getcontext \
-		    bug-strtod \
-		    bug-strtod2 \
-		    test-a64l \
-		    test-at_quick_exit-race \
-		    test-atexit-race \
-		    test-bz22786 \
-		    test-canon \
-		    test-canon2 \
-		    test-cxa_atexit-race \
-		    test-cxa_atexit-race2 \
-		    test-dlclose-exit-race \
-		    test-on_exit-race \
-		    testdiv \
-		    testmb \
-		    testmb2 \
-		    testrand \
-		    testsort \
-		    tst-at_quick_exit \
-		    tst-atexit \
-		    tst-atof1 \
-		    tst-atof2 \
-		    tst-bsearch \
-		    tst-bz20544 \
-		    tst-canon-bz26341 \
-		    tst-cxa_atexit \
-		    tst-environ \
-		    tst-getrandom \
-		    tst-limits \
-		    tst-makecontext \
-		    tst-makecontext-align \
-		    tst-makecontext2 \
-		    tst-makecontext3 \
-		    tst-on_exit \
-		    tst-qsort \
-		    tst-qsort2 \
-		    tst-quick_exit \
-		    tst-rand48 \
-		    tst-rand48-2 \
-		    tst-random \
-		    tst-random2 \
-		    tst-realpath \
-		    tst-secure-getenv \
-		    tst-setcontext \
-		    tst-setcontext2 \
-		    tst-setcontext3 \
-		    tst-setcontext4 \
-		    tst-setcontext5 \
-		    tst-setcontext6 \
-		    tst-setcontext7 \
-		    tst-setcontext8 \
-		    tst-setcontext9 \
-		    tst-strfmon_l \
-		    tst-strfrom \
-		    tst-strfrom-locale \
-		    tst-strtod \
-		    tst-strtod-nan-locale \
-		    tst-strtod-nan-sign \
-		    tst-strtod-overflow \
-		    tst-strtod-round \
-		    tst-strtod-underflow \
-		    tst-strtod2 \
-		    tst-strtod5 \
-		    tst-strtod6 \
-		    tst-strtol \
-		    tst-strtol-locale \
-		    tst-strtoll \
-		    tst-swapcontext1 \
-		    tst-thread-quick_exit \
-		    tst-tininess \
-		    tst-unsetenv1 \
-		    tst-width \
-		    tst-width-stdint \
-		    tst-xpg-basename
+tests := \
+  bug-fmtmsg1 \
+  bug-getcontext \
+  bug-strtod \
+  bug-strtod2 \
+  test-a64l \
+  test-at_quick_exit-race \
+  test-atexit-race \
+  test-bz22786 \
+  test-canon \
+  test-canon2 \
+  test-cxa_atexit-race \
+  test-cxa_atexit-race2 \
+  test-dlclose-exit-race \
+  test-on_exit-race \
+  testdiv \
+  testmb \
+  testmb2 \
+  testrand \
+  testsort \
+  tst-at_quick_exit \
+  tst-atexit \
+  tst-atof1 \
+  tst-atof2 \
+  tst-bsearch \
+  tst-bz20544 \
+  tst-canon-bz26341 \
+  tst-cxa_atexit \
+  tst-environ \
+  tst-getrandom \
+  tst-limits \
+  tst-makecontext \
+  tst-makecontext-align \
+  tst-makecontext2 \
+  tst-makecontext3 \
+  tst-on_exit \
+  tst-qsort \
+  tst-qsort2 \
+  tst-quick_exit \
+  tst-rand48 \
+  tst-rand48-2 \
+  tst-random \
+  tst-random2 \
+  tst-realpath \
+  tst-secure-getenv \
+  tst-setcontext \
+  tst-setcontext2 \
+  tst-setcontext3 \
+  tst-setcontext4 \
+  tst-setcontext5 \
+  tst-setcontext6 \
+  tst-setcontext7 \
+  tst-setcontext8 \
+  tst-setcontext9 \
+  tst-strfmon_l \
+  tst-strfrom \
+  tst-strfrom-locale \
+  tst-strtod \
+  tst-strtod-nan-locale \
+  tst-strtod-nan-sign \
+  tst-strtod-overflow \
+  tst-strtod-round \
+  tst-strtod-underflow \
+  tst-strtod2 \
+  tst-strtod5 \
+  tst-strtod6 \
+  tst-strtol \
+  tst-strtol-locale \
+  tst-strtoll \
+  tst-swapcontext1 \
+  tst-thread-quick_exit \
+  tst-tininess \
+  tst-unsetenv1 \
+  tst-width \
+  tst-width-stdint \
+  tst-xpg-basename \
+# tests
 
 tests-internal	:= tst-strtod1i tst-strtod3 tst-strtod4 tst-strtod5i \
 		   tst-tls-atexit tst-tls-atexit-nodelete
-- 
2.34.1

Re: [PATCH] stdlib: Fix formatting of tests list in Makefile

[Florian Weimer]

* Siddhesh Poyarekar:

> Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

Looks good to me.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian

Re: [glibc] stdlib: Sort tests in Makefile

[Paul A. Clarke]

On Thu, Jan 13, 2022 at 11:48:41AM +0100, Florian Weimer via Libc-alpha wrote:
> * Siddhesh Poyarekar via Glibc-cvs:
> 
> > +tests		:=  bug-fmtmsg1 \
> > +		    bug-getcontext \
> 
> > +		    tst-width \
> > +		    tst-width-stdint \
> > +		    tst-xpg-basename
> 
> Please use two-space indentation like elsewhere, and add the trailing
> “# tests”.  Thanks.

Was the convention to add a backslash to the _last_ item put into practice?
This is to avoid changing the last item when appending a new item.
I recall a discussion about this a while ago, but not the conclusion.

PC

Re: [glibc] stdlib: Sort tests in Makefile

[Florian Weimer]

* Paul A. Clarke:

> On Thu, Jan 13, 2022 at 11:48:41AM +0100, Florian Weimer via Libc-alpha wrote:
>> * Siddhesh Poyarekar via Glibc-cvs:
>> 
>> > +tests		:=  bug-fmtmsg1 \
>> > +		    bug-getcontext \
>> 
>> > +		    tst-width \
>> > +		    tst-width-stdint \
>> > +		    tst-xpg-basename
>> 
>> Please use two-space indentation like elsewhere, and add the trailing
>> “# tests”.  Thanks.
>
> Was the convention to add a backslash to the _last_ item put into practice?
> This is to avoid changing the last item when appending a new item.
> I recall a discussion about this a while ago, but not the conclusion.

The was a concern about \ munging the next line, but I think we mitigate
that with the added comment.

Thanks,
Florian