* [PATCH] Remove spurious references to _dl_open_hook
@ 2022-08-01 9:14 Florian Weimer
2022-08-01 13:42 ` Adhemerval Zanella Netto
0 siblings, 1 reply; 2+ messages in thread
From: Florian Weimer @ 2022-08-01 9:14 UTC (permalink / raw)
To: libc-alpha
_dl_open_hook was removed in commit 466c1ea15f461edb8e3ffaf5d86d708
("dlfcn: Rework static dlopen hooks").
---
libio/vtables.c | 4 ----
malloc/arena.c | 5 -----
2 files changed, 9 deletions(-)
diff --git a/libio/vtables.c b/libio/vtables.c
index 499f0039cb..50acab7f21 100644
--- a/libio/vtables.c
+++ b/libio/vtables.c
@@ -25,10 +25,6 @@
void (*IO_accept_foreign_vtables) (void) attribute_hidden;
-/* Used to detected multiple libcs. */
-extern struct dl_open_hook *_dl_open_hook;
-libc_hidden_proto (_dl_open_hook);
-
#else /* !SHARED */
/* Used to check whether static dlopen support is needed. */
diff --git a/malloc/arena.c b/malloc/arena.c
index 0a684a720d..defd25c8a6 100644
--- a/malloc/arena.c
+++ b/malloc/arena.c
@@ -300,11 +300,6 @@ next_env_entry (char ***position)
#endif
-#ifdef SHARED
-extern struct dl_open_hook *_dl_open_hook;
-libc_hidden_proto (_dl_open_hook);
-#endif
-
#if USE_TCACHE
static void tcache_key_initialize (void);
#endif
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove spurious references to _dl_open_hook
2022-08-01 9:14 [PATCH] Remove spurious references to _dl_open_hook Florian Weimer
@ 2022-08-01 13:42 ` Adhemerval Zanella Netto
0 siblings, 0 replies; 2+ messages in thread
From: Adhemerval Zanella Netto @ 2022-08-01 13:42 UTC (permalink / raw)
To: Florian Weimer, libc-alpha
On 01/08/22 06:14, Florian Weimer via Libc-alpha wrote:
> _dl_open_hook was removed in commit 466c1ea15f461edb8e3ffaf5d86d708
> ("dlfcn: Rework static dlopen hooks").
>
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> libio/vtables.c | 4 ----
> malloc/arena.c | 5 -----
> 2 files changed, 9 deletions(-)
>
> diff --git a/libio/vtables.c b/libio/vtables.c
> index 499f0039cb..50acab7f21 100644
> --- a/libio/vtables.c
> +++ b/libio/vtables.c
> @@ -25,10 +25,6 @@
>
> void (*IO_accept_foreign_vtables) (void) attribute_hidden;
>
> -/* Used to detected multiple libcs. */
> -extern struct dl_open_hook *_dl_open_hook;
> -libc_hidden_proto (_dl_open_hook);
> -
> #else /* !SHARED */
>
> /* Used to check whether static dlopen support is needed. */
> diff --git a/malloc/arena.c b/malloc/arena.c
> index 0a684a720d..defd25c8a6 100644
> --- a/malloc/arena.c
> +++ b/malloc/arena.c
> @@ -300,11 +300,6 @@ next_env_entry (char ***position)
> #endif
>
>
> -#ifdef SHARED
> -extern struct dl_open_hook *_dl_open_hook;
> -libc_hidden_proto (_dl_open_hook);
> -#endif
> -
> #if USE_TCACHE
> static void tcache_key_initialize (void);
> #endif
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-01 13:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-01 9:14 [PATCH] Remove spurious references to _dl_open_hook Florian Weimer
2022-08-01 13:42 ` Adhemerval Zanella Netto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).