From: Carlos O'Donell <carlos@redhat.com>
To: Steve Ellcey <sellcey@caviumnetworks.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] Fix -Wformat-length warning in time/tst-strptime2.c
Date: Wed, 02 Nov 2016 20:55:00 -0000 [thread overview]
Message-ID: <8cd86260-3ce5-dfa8-477c-f2981b29ac3d@redhat.com> (raw)
In-Reply-To: <1478116026.2891.53.camel@caviumnetworks.com>
On 11/02/2016 03:47 PM, Steve Ellcey wrote:
> Here is an updated version of my earlier patch, I hadn't tested the
> original one with an old GCC so I hadn't realized I needed to put the
> DIAG_IGNORE_NEEDS_COMMENT in an ifdef. This version was tested with
> GCC 5.4 and GCC 7.0 with no regressions.
>
> I also double checked that the test program is deliberately using
> snprintf to truncate the output so changing the test by increasing the
> buffer size and avoiding the warnings that way would change what was
> being tested.
>
> OK to checkin?
LGTM.
c.
prev parent reply other threads:[~2016-11-02 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 16:28 Steve Ellcey
2016-11-02 19:47 ` Steve Ellcey
2016-11-02 20:55 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cd86260-3ce5-dfa8-477c-f2981b29ac3d@redhat.com \
--to=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=sellcey@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).