Re: [PATCH] malloc: Correct the documentation of the top_pad default

[Alejandro Colomar <alx.manpages@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1175 bytes --]

Hi Florian,

On 8/4/22 10:48, Florian Weimer via Libc-alpha wrote:
> DEFAULT_TOP_PAD is defined as 131072 in
> sysdeps/generic/malloc-machine.h.
> 
> ---
>   elf/dl-tunables.list           | 1 +
>   elf/tst-rtld-list-tunables.exp | 2 +-
>   manual/tunables.texi           | 2 +-
>   3 files changed, 3 insertions(+), 2 deletions(-)
> 

[...]

> diff --git a/manual/tunables.texi b/manual/tunables.texi
> index 83cdcdac6d..ffd50a3fe2 100644
> --- a/manual/tunables.texi
> +++ b/manual/tunables.texi
> @@ -143,7 +143,7 @@ number of bytes to retain when shrinking any of the arenas.  This provides the
>   necessary hysteresis in heap size such that excessive amounts of system calls
>   can be avoided.
>   
> -The default value of this tunable is @samp{0}.
> +The default value of this tunable is @samp{131072} (128 KB).

I don't know how much glibc uses KB vs KiB, but I'd like to be pedantic 
here and suggest using KiB (maybe this requires a global change to keep 
consistency).  See units(7).

Cheers,

Alex

>   @end deftp
>   
>   @deftp Tunable glibc.malloc.perturb
> 

-- 
Alejandro Colomar
<http://www.alejandro-colomar.es/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]