From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] malloc: Correct the documentation of the top_pad default
Date: Thu, 4 Aug 2022 11:15:33 -0400 [thread overview]
Message-ID: <6db9b99b-1ea2-c57c-8b6e-40cf38169460@gotplt.org> (raw)
In-Reply-To: <878ro4jb1z.fsf@oldenburg.str.redhat.com>
On 2022-08-04 11:14, Florian Weimer wrote:
> * Siddhesh Poyarekar:
>
>> On 2022-08-04 04:48, Florian Weimer via Libc-alpha wrote:
>>> DEFAULT_TOP_PAD is defined as 131072 in
>>> sysdeps/generic/malloc-machine.h.
>>
>> LGTM, but I wonder if we should tighten this so that it doesn't appear
>> that DEFAULT_TOP_PAD could be 0 in any of our build configurations.
>> e.g. we could replace the definition with a #error "define
>> DEFAULT_TOP_PAD" or something like that to ensure that it's always
>> defined through malloc-machine.h. What do you think?
>
> We could just remove the various #ifdefs, I guess. The other question
> is whether we can use the constant in the tunable definition file. I
> haven't investigate any of this.
>
> Should I push my change in the meantime?
Yes please.
Thanks,
Sid
next prev parent reply other threads:[~2022-08-04 15:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 8:48 Florian Weimer
2022-08-04 14:51 ` Siddhesh Poyarekar
2022-08-04 15:14 ` Florian Weimer
2022-08-04 15:15 ` Siddhesh Poyarekar [this message]
2022-08-04 15:46 ` Alejandro Colomar
2022-08-04 15:54 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6db9b99b-1ea2-c57c-8b6e-40cf38169460@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).