From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
Florian Weimer <fweimer@redhat.com>
Cc: Joe Simmons-Talbott <josimmon@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] setipv4sourcefilter: Avoid using alloca.
Date: Thu, 25 May 2023 08:25:36 -0400 [thread overview]
Message-ID: <8efcede8-fe0f-351b-3376-617a2292d9b5@gotplt.org> (raw)
In-Reply-To: <bdbce4d5-5235-de17-8a81-cdd5032bee02@linaro.org>
On 2023-05-25 08:20, Adhemerval Zanella Netto wrote:
>>>> We already save/restore errno on free since 69fda43b8dd795c. We can optimize
>>>> it a bit by adding munmap/mprotect that calls INTERNAL_SYSCALL_CALL, but I
>>>> am not sure if the complexity will really be worth here.
>>>
>>> Ah, right, then scratch_buffer_free should be okay, too.
>>
>> I guess, but should we still stick to preserving errno to account for lack of errno preservation in non-glibc malloc implementations?
>
> I don't think it is worth, this requirement will be in the next POSIX [1] and
> it also means that we will need to propagate this assumption on all internal
> glibc code (which is only boilerplate code in the end).
>
> [1] https://www.austingroupbugs.net/view.php?id=385
In that case, LGTM.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
prev parent reply other threads:[~2023-05-25 12:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 18:18 Joe Simmons-Talbott
2023-05-25 2:09 ` Siddhesh Poyarekar
2023-05-25 7:33 ` Florian Weimer
2023-05-25 11:04 ` Adhemerval Zanella Netto
2023-05-25 11:27 ` Florian Weimer
2023-05-25 11:57 ` Siddhesh Poyarekar
2023-05-25 12:20 ` Adhemerval Zanella Netto
2023-05-25 12:25 ` Siddhesh Poyarekar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8efcede8-fe0f-351b-3376-617a2292d9b5@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=josimmon@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).