From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: libc-alpha@sourceware.org
Subject: [PING][PATCH] Move tst-resolv-res_init-multi to xtests
Date: Mon, 28 Jun 2021 09:48:13 +0530 [thread overview]
Message-ID: <8f314a1d-85a3-b987-4d08-ecb87054ecdb@gotplt.org> (raw)
In-Reply-To: <20210622044449.4091104-1-siddhesh@sourceware.org>
Hi, any objections to this move?
Siddhesh
On 6/22/21 10:14 AM, Siddhesh Poyarekar via Libc-alpha wrote:
> Tests that need network access may cause false failures due to network
> glitches because of which they are typically added as xtests. See for
> example posix/tst-getaddrinfo{4,5}.c. Move tst-resolv-res_init-multi
> also to xtests so that it is not executed in a regular test run.
> ---
> resolv/Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/resolv/Makefile b/resolv/Makefile
> index 3fbc320ee1..3e17fda571 100644
> --- a/resolv/Makefile
> +++ b/resolv/Makefile
> @@ -57,7 +57,6 @@ tests += \
> tst-resolv-edns \
> tst-resolv-network \
> tst-resolv-nondecimal \
> - tst-resolv-res_init-multi \
> tst-resolv-search \
> tst-resolv-trailing \
>
> @@ -103,6 +102,9 @@ xtests += tst-resolv-qtypes
>
> # This test has dropped packet tests and runs for a long time.
> xtests += tst-resolv-rotate
> +
> +# This test needs a functioning network to succeed.
> +xtests += tst-resolv-res_init-multi
> endif
> extra-libs-others = $(extra-libs)
> libresolv-routines := res_comp res_debug \
>
next prev parent reply other threads:[~2021-06-28 4:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 4:44 [PATCH] " Siddhesh Poyarekar
2021-06-28 4:18 ` Siddhesh Poyarekar [this message]
2021-06-28 4:38 ` Florian Weimer
2021-06-28 4:45 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f314a1d-85a3-b987-4d08-ecb87054ecdb@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).