public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Vivek Das Mohapatra <vivek@collabora.com>, libc-alpha@sourceware.org
Subject: Re: [RFC][PATCH v10 4/7] Add DT_GNU_FLAGS_1/DF_GNU_1_UNIQUE to glibc DSOs (bug 22745)
Date: Fri, 28 May 2021 13:59:39 -0300	[thread overview]
Message-ID: <8f7df6eb-951d-0b56-c90a-cc305c218589@linaro.org> (raw)
In-Reply-To: <b3559843-4675-37b1-b107-a1ae5b6f5cd0@linaro.org>

> On 22/03/2021 12:41, Vivek Das Mohapatra via Libc-alpha wrote:

>> @@ -636,6 +637,17 @@ build-shlib-objlist = $(build-module-helper-objlist) \
>>  # Also omits crti.o and crtn.o, which we do not want
>>  # since we define our own `.init' section specially.
>>  LDFLAGS-c.so = -nostdlib -nostartfiles
>> +
>> +# The stub dynamic-notes.os should not have weak/undefined symbol magic in it.
>> +# It's not really part of the internals, rather it is a vector for linker magic
>> +# which we need when the linker isn't new enough:
>> +%/dynamic-notes.os: CPPFLAGS += -UMODULE_NAME

Although it seems correct to built it without defining MODULE_NAME, 
I wonder if there is a simpler way to define as MODULE_NAME=nonlib
(it seems be more correct than not defining any module name).

>> +%/dynamic-notes.os: dynamic-notes.c
I think this is not really required.

  reply	other threads:[~2021-05-28 16:59 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22 15:41 [RFC][PATCH v10 0/7] Implementation of RTLD_SHARED for dlmopen Vivek Das Mohapatra
2021-03-22 15:41 ` [RFC][PATCH v10 1/7] Define a new dynamic section tag - DT_GNU_FLAGS_1 (bug 22745) Vivek Das Mohapatra
2021-05-28 14:53   ` Adhemerval Zanella
2021-03-22 15:41 ` [RFC][PATCH v10 2/7] Abstract loaded-DSO search code into a helper function Vivek Das Mohapatra
2021-05-28 14:53   ` Adhemerval Zanella
2021-03-22 15:41 ` [RFC][PATCH v10 3/7] Use the new DSO finder " Vivek Das Mohapatra
2021-05-28 14:53   ` Adhemerval Zanella
2021-03-22 15:41 ` [RFC][PATCH v10 4/7] Add DT_GNU_FLAGS_1/DF_GNU_1_UNIQUE to glibc DSOs (bug 22745) Vivek Das Mohapatra
2021-05-28 14:53   ` Adhemerval Zanella
2021-05-28 16:59     ` Adhemerval Zanella [this message]
2021-05-28 17:18     ` Andreas Schwab
2021-03-22 15:41 ` [RFC][PATCH v10 5/7] Implement dlmopen RTLD_SHARED flag " Vivek Das Mohapatra
2021-05-28 17:32   ` Adhemerval Zanella
2021-05-28 18:02     ` Adhemerval Zanella
2021-06-02 15:42       ` Vivek Das Mohapatra
2021-05-28 23:22     ` Vivek Das Mohapatra
2021-03-22 15:41 ` [RFC][PATCH v10 6/7] Add dlmopen / RTLD_SHARED tests Vivek Das Mohapatra
2021-03-22 15:41 ` [RFC][PATCH v10 7/7] Restore separate libc loading for the TLS/namespace storage test Vivek Das Mohapatra
2021-03-25 15:15 ` [RFC][PATCH v10 0/7] Implementation of RTLD_SHARED for dlmopen Vivek Das Mohapatra
2021-04-13 17:02 ` Vivek Das Mohapatra
2021-04-29 15:25   ` Vivek Das Mohapatra
2021-05-11 17:42     ` Vivek Das Mohapatra
2021-05-17 19:08       ` [PING][PATCH " Vivek Das Mohapatra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f7df6eb-951d-0b56-c90a-cc305c218589@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    --cc=vivek@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).