From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Noah Goldstein <goldstein.w.n@gmail.com>,
Richard Henderson <richard.henderson@linaro.org>
Cc: Richard Henderson <rth@twiddle.net>, libc-alpha@sourceware.org
Subject: Re: [PATCH v5 08/17] string: Improve generic strchrnul
Date: Tue, 10 Jan 2023 15:19:08 -0300 [thread overview]
Message-ID: <94c253ec-7a99-0e6a-5714-e67267ce88c9@linaro.org> (raw)
In-Reply-To: <CAFUsyfK-+_h3FP4Ewwn+=d1PpmumLsES4eXZRTLbGSJVzrVyOw@mail.gmail.com>
On 10/01/23 14:16, Noah Goldstein wrote:
> On Tue, Jan 10, 2023 at 8:24 AM Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> On 1/10/23 06:18, Adhemerval Zanella Netto via Libc-alpha wrote:
>>> static __always_inline op_t
>>> check_mask (op_t word, uintptr_t s_int)
>>> {
>>> if (__BYTE_ORDER == __LITTLE_ENDIAN)
>>> return word >> (CHAR_BIT * (s_int % sizeof (s_int)));
>>> else
>>> return word << (CHAR_BIT * (s_int % sizeof (s_int)));
>>> }
>>
>> sizeof(op_t), which is usually the same size, but doesn't have to be.
>>
> Are we aligning by sizeof(op_t) or sizeof(void *)?
> The former then `word_containing` will also need to be changed.
>
> If the latter then sizeof(s_int) is correct.
The read/write operation are being done by op_t, so it makes sense to use
op_t on the sizeof. It would really matter on ABIs with op_t different
than uintptr_t (mips64n32 and x32).
next prev parent reply other threads:[~2023-01-10 18:19 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 19:59 [PATCH v5 00/17] Improve generic string routines Adhemerval Zanella
2022-09-19 19:59 ` [PATCH v5 01/17] Parameterize op_t from memcopy.h Adhemerval Zanella
2022-09-19 19:59 ` [PATCH v5 02/17] Parameterize OP_T_THRES " Adhemerval Zanella
2022-09-20 10:49 ` Carlos O'Donell
2022-09-19 19:59 ` [PATCH v5 03/17] Add string-maskoff.h generic header Adhemerval Zanella
2022-09-20 11:43 ` Carlos O'Donell
2022-09-22 17:31 ` Adhemerval Zanella Netto
2023-01-05 22:49 ` Noah Goldstein
2023-01-05 23:26 ` Alejandro Colomar
2023-01-09 18:19 ` Adhemerval Zanella Netto
2023-01-09 18:02 ` Adhemerval Zanella Netto
2022-09-19 19:59 ` [PATCH v5 04/17] Add string vectorized find and detection functions Adhemerval Zanella
2023-01-05 22:53 ` Noah Goldstein
2023-01-09 18:51 ` Adhemerval Zanella Netto
2023-01-05 23:04 ` Noah Goldstein
2023-01-09 19:34 ` Adhemerval Zanella Netto
2022-09-19 19:59 ` [PATCH v5 05/17] string: Improve generic strlen Adhemerval Zanella
2022-09-19 19:59 ` [PATCH v5 06/17] string: Improve generic strnlen Adhemerval Zanella
2022-09-19 19:59 ` [PATCH v5 07/17] string: Improve generic strchr Adhemerval Zanella
2023-01-05 23:09 ` Noah Goldstein
2023-01-05 23:19 ` Noah Goldstein
2023-01-09 19:39 ` Adhemerval Zanella Netto
2022-09-19 19:59 ` [PATCH v5 08/17] string: Improve generic strchrnul Adhemerval Zanella
2023-01-05 23:17 ` Noah Goldstein
2023-01-09 20:35 ` Adhemerval Zanella Netto
2023-01-09 20:49 ` Richard Henderson
2023-01-09 20:59 ` Noah Goldstein
2023-01-09 21:01 ` Noah Goldstein
2023-01-09 23:33 ` Richard Henderson
2023-01-10 14:18 ` Adhemerval Zanella Netto
2023-01-10 16:24 ` Richard Henderson
2023-01-10 17:16 ` Noah Goldstein
2023-01-10 18:19 ` Adhemerval Zanella Netto [this message]
2023-01-10 17:17 ` Noah Goldstein
2023-01-10 18:16 ` Adhemerval Zanella Netto
2022-09-19 19:59 ` [PATCH v5 09/17] string: Improve generic strcmp Adhemerval Zanella
2022-09-19 19:59 ` [PATCH v5 10/17] string: Improve generic memchr Adhemerval Zanella
2023-01-05 23:47 ` Noah Goldstein
2023-01-09 20:50 ` Adhemerval Zanella Netto
2023-01-05 23:49 ` Noah Goldstein
2023-01-09 20:51 ` Adhemerval Zanella Netto
2023-01-09 21:26 ` Noah Goldstein
2023-01-10 14:33 ` Adhemerval Zanella Netto
2022-09-19 19:59 ` [PATCH v5 11/17] string: Improve generic memrchr Adhemerval Zanella
2023-01-05 23:51 ` Noah Goldstein
2022-09-19 19:59 ` [PATCH v5 12/17] hppa: Add memcopy.h Adhemerval Zanella
2022-09-19 19:59 ` [PATCH v5 13/17] hppa: Add string-fzb.h and string-fzi.h Adhemerval Zanella
2022-09-19 19:59 ` [PATCH v5 14/17] alpha: " Adhemerval Zanella
2022-09-19 19:59 ` [PATCH v5 15/17] arm: Add string-fza.h Adhemerval Zanella
2022-09-19 19:59 ` [PATCH v5 16/17] powerpc: " Adhemerval Zanella
2022-09-19 19:59 ` [PATCH v5 17/17] sh: Add string-fzb.h Adhemerval Zanella
2022-12-05 17:07 ` [PATCH v5 00/17] Improve generic string routines Xi Ruoyao
2023-01-05 21:56 ` Adhemerval Zanella Netto
2023-01-05 23:52 ` Noah Goldstein
2023-01-06 13:43 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94c253ec-7a99-0e6a-5714-e67267ce88c9@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).