From: Carlos O'Donell <carlos@redhat.com>
To: Florian Weimer <fw@deneb.enyo.de>,
Andreas Schwab via Libc-alpha <libc-alpha@sourceware.org>
Cc: Andreas Schwab <schwab@suse.de>
Subject: Re: [PATCH] Account for grouping in printf width (bug 23432)
Date: Sun, 22 Jan 2023 18:20:52 -0500 [thread overview]
Message-ID: <9531aa0c-bb05-ab2f-fd48-0751fb6f4393@redhat.com> (raw)
In-Reply-To: <87pmb8ktdo.fsf@mid.deneb.enyo.de>
On 1/21/23 06:40, Florian Weimer wrote:
> * Andreas Schwab via Libc-alpha:
>
>> diff --git a/stdio-common/Makefile b/stdio-common/Makefile
>> index 6e9d104524..b46d932a20 100644
>> --- a/stdio-common/Makefile
>> +++ b/stdio-common/Makefile
>> @@ -195,6 +195,7 @@ tests := \
>> tst-gets \
>> tst-grouping \
>> tst-grouping2 \
>> + tst-grouping3 \
>> tst-long-dbl-fphex \
>> tst-memstream-string \
>> tst-obprintf \
>
> Missing $(gen-locales) dependency. The change itself seems okay, it
> seems to align with POSIX. Not sure if this is still possibly to
> apply during the freeze.
I'd like to avoid a partial fix like this just before we release 2.27.
My preference would be to review this more thoroughly, apply it when 2.28 opens,
and then backport when we have confidence the issue is resolved.
--
Cheers,
Carlos.
next prev parent reply other threads:[~2023-01-22 23:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 11:50 Andreas Schwab
2023-01-21 11:40 ` Florian Weimer
2023-01-22 23:20 ` Carlos O'Donell [this message]
2023-02-02 9:51 ` Andreas Schwab
2023-02-02 10:45 ` Florian Weimer
2023-02-02 10:54 ` Andreas Schwab
2023-02-02 12:00 ` Xi Ruoyao
2023-02-02 13:10 ` Vincent Lefevre
2023-02-02 13:40 ` Carlos O'Donell
2023-02-04 16:22 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9531aa0c-bb05-ab2f-fd48-0751fb6f4393@redhat.com \
--to=carlos@redhat.com \
--cc=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).