[PATCH v2] AArch64: Fix HP_TIMING_DIFF computation

[PATCH v2] AArch64: Fix HP_TIMING_DIFF computation

[Tang, Jun]

[-- Attachment #1.1: Type: text/plain, Size: 203 bytes --]

Attached is the updated patch that allows max execution time to be 1024 seconds before overflowing.

Link to the bug report - https://sourceware.org/bugzilla/show_bug.cgi?id=29329.

Regards,

Jun

[-- Attachment #2: hp-timing-patchv2.diff --]
[-- Type: application/octet-stream, Size: 541 bytes --]

diff --git a/sysdeps/aarch64/hp-timing.h b/sysdeps/aarch64/hp-timing.h
index f7f7ac7cae..7c6be072c4 100644
--- a/sysdeps/aarch64/hp-timing.h
+++ b/sysdeps/aarch64/hp-timing.h
@@ -41,7 +41,7 @@ typedef uint64_t hp_timing_t;
 #define HP_TIMING_DIFF(Diff, Start, End)			\
 ({  hp_timing_t freq;						\
     __asm__ __volatile__ ("mrs %0, cntfrq_el0" : "=r" (freq));	\
-   (Diff) = ((End) - (Start)) * (UINT64_C(1000000000) / freq);	\
+   (Diff) = (((End) - (Start)) * UINT64_C(1000000000 >> 6)) / (freq >> 6); \
 })
 
 #endif	/* hp-timing.h */

RE: [PATCH v2] AArch64: Fix HP_TIMING_DIFF computation

[Tang, Jun]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

Please let me know what else needs to be done to get this patch merged.

Regards,

Jun

From: Tang, Jun
Sent: Wednesday, February 8, 2023 9:58 AM
To: 'GNU C Library' <libc-alpha@sourceware.org>
Subject: [PATCH v2] AArch64: Fix HP_TIMING_DIFF computation

Attached is the updated patch that allows max execution time to be 1024 seconds before overflowing.

Link to the bug report - https://sourceware.org/bugzilla/show_bug.cgi?id=29329.

Regards,

Jun

Re: [PATCH v2] AArch64: Fix HP_TIMING_DIFF computation

[Wilco Dijkstra]

Hi Jun,

I've merged your patch, see commit 311a7e0256975275d97077f1af338bc9caf0c837 .

Cheers,
Wilco

RE: [PATCH v2] AArch64: Fix HP_TIMING_DIFF computation

[Tang, Jun]

Wilco,

Thanks for the update,

Jun

-----Original Message-----
From: Wilco Dijkstra <Wilco.Dijkstra@arm.com> 
Sent: Wednesday, February 22, 2023 11:27 AM
To: Tang, Jun <juntangc@amazon.com>
Cc: 'GNU C Library' <libc-alpha@sourceware.org>
Subject: RE: [EXTERNAL][PATCH v2] AArch64: Fix HP_TIMING_DIFF computation

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.



Hi Jun,

I've merged your patch, see commit 311a7e0256975275d97077f1af338bc9caf0c837 .

Cheers,
Wilco