Re: [PATCH] S390: Fix elf/tst-audit25[ab]

[Stefan Liebler <stli@linux.ibm.com>]

On 07/04/2022 15:36, Adhemerval Zanella via Libc-alpha wrote:
> 
> 
> On 07/04/2022 08:59, Stefan Liebler via Libc-alpha wrote:
>> If glibc is configured with --disable-default-pie and build on
>> s390 with -O3, the tests elf/tst-audit25a and elf/tst-audit25b are
>> failing as there are additional la_symbind lines for free and malloc.
>> It turns out that those belong to the executable. In fact those are
>> the PLT-stubs. Furthermore la_symbind is also called for calloc and
>> realloc symbols, but those belong to libc.
>>
>> Those functions are not called at all, but dlsym'ed in
>> elf/dl-minimal.c:
>> __rtld_malloc_init_real (struct link_map *main_map)
>> {
>> ...
>>   void *new_calloc = lookup_malloc_symbol (main_map, "calloc", &version);
>>   void *new_free = lookup_malloc_symbol (main_map, "free", &version);
>>   void *new_malloc = lookup_malloc_symbol (main_map, "malloc", &version);
>>   void *new_realloc = lookup_malloc_symbol (main_map, "realloc", &version);
>> ...
>> }
>>
>> Therefore, this commit just ignored symbols with LA_SYMB_DLSYM flag.
> 
> LGTM, thank.  Why don't we see in other configuration and/or architecture?
> What s390 is doing different here?
> 
> Reviewed-by: Adheemrval Zanella  <adhemerval.zanella@linaro.org>
> 

Thanks.
Then I'll commit the patch.

You are right I have not seen it on x86_64. Perhaps it triggers
something in s390x-code in ld regarding -Bsymbolic and
pointer-equality-reasons. But this is only a guess.

Thanks,
Stefan