From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Alejandro Colomar <alx.manpages@gmail.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH v2] stdio-common/printf-prs.c: Reword comment
Date: Mon, 29 Mar 2021 18:04:20 -0300 [thread overview]
Message-ID: <97ee7152-684a-1351-1ac6-f0d7b1b01ceb@linaro.org> (raw)
In-Reply-To: <20210324182915.29042-1-alx.manpages@gmail.com>
On 24/03/2021 15:29, Alejandro Colomar via Libc-alpha wrote:
> 'this' can be understood as the current parameter, but in this case it
> is meaning the other one, the one holding the width/precission.
>
> 'it' better describes that parameter, differentiating it from the
> one corresponding to the current specifier.
>
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
We don't use SCO, but rather Copyright assignment. The rest looks good
to me (although I am not a native speaker).
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> stdio-common/printf-prs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/stdio-common/printf-prs.c b/stdio-common/printf-prs.c
> index 1d4e00553d..8ebf09a0a9 100644
> --- a/stdio-common/printf-prs.c
> +++ b/stdio-common/printf-prs.c
> @@ -72,11 +72,11 @@ parse_printf_format (const char *fmt, size_t n, int *argtypes)
> /* Parse this spec. */
> nargs += __parse_one_specmb (f, nargs, &spec, &max_ref_arg);
>
> - /* If the width is determined by an argument this is an int. */
> + /* If the width is determined by an argument, it is an int. */
> if (spec.width_arg != -1 && (size_t) spec.width_arg < n)
> argtypes[spec.width_arg] = PA_INT;
>
> - /* If the precision is determined by an argument this is an int. */
> + /* If the precision is determined by an argument, it is an int. */
> if (spec.prec_arg != -1 && (size_t) spec.prec_arg < n)
> argtypes[spec.prec_arg] = PA_INT;
>
>
next prev parent reply other threads:[~2021-03-29 21:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <830f204e-b1bd-424a-73b8-275b18582c7e@gmail.com>
2021-03-24 18:29 ` Alejandro Colomar
2021-03-29 21:04 ` Adhemerval Zanella [this message]
2021-03-29 21:53 ` Alejandro Colomar (man-pages)
2021-03-30 12:12 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97ee7152-684a-1351-1ac6-f0d7b1b01ceb@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=alx.manpages@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).