public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Carlos O'Donell <carlos@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH 4/5] misc: Reformat Makefile.
Date: Thu, 18 May 2023 12:06:16 -0400	[thread overview]
Message-ID: <9892ef99-434d-f420-3e36-efa17cf9a199@gotplt.org> (raw)
In-Reply-To: <20230518130325.59309-5-carlos@redhat.com>



On 2023-05-18 09:03, Carlos O'Donell wrote:
> Reflow Makefile.
> Sort using updated scripts/sort-makefile-lines.py.
> 
> Code generation is changed as routines are linked in sorted order
> as expected.
> 
> No regressions on x86_64 and i686.
> ---

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

>   misc/Makefile | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/misc/Makefile b/misc/Makefile
> index 1a21347f5e..84aa4cb0ad 100644
> --- a/misc/Makefile
> +++ b/misc/Makefile
> @@ -156,14 +156,14 @@ routines := \
>     munlockall \
>     munmap \
>     preadv \
> -  preadv64 \
>     preadv2 \
> +  preadv64 \
>     preadv64v2 \
>     pselect \
>     ptrace \
>     pwritev \
> -  pwritev64 \
>     pwritev2 \
> +  pwritev64 \
>     pwritev64v2 \
>     qefgcvt \
>     qefgcvt_r \
> @@ -243,8 +243,8 @@ tests := \
>     tst-mntent-escape \
>     tst-mntent2 \
>     tst-preadvwritev \
> -  tst-preadvwritev64 \
>     tst-preadvwritev2 \
> +  tst-preadvwritev64 \
>     tst-preadvwritev64v2 \
>     tst-pselect \
>     tst-select \

  reply	other threads:[~2023-05-18 16:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-18 13:03 [PATCH 0/5] Fix defect in sort-makefile-lines.py Carlos O'Donell
2023-05-18 13:03 ` [PATCH 1/5] scripts: sort-makefile-lines.py Carlos O'Donell
2023-05-18 15:56   ` Siddhesh Poyarekar
2023-05-18 16:53     ` Carlos O'Donell
2023-05-18 13:03 ` [PATCH 2/5] elf: Adjust tests in Makefile Carlos O'Donell
2023-05-18 16:05   ` Siddhesh Poyarekar
2023-05-18 13:03 ` [PATCH 3/5] stdio-common: " Carlos O'Donell
2023-05-18 16:05   ` Siddhesh Poyarekar
2023-05-18 13:03 ` [PATCH 4/5] misc: Reformat Makefile Carlos O'Donell
2023-05-18 16:06   ` Siddhesh Poyarekar [this message]
2023-05-18 13:03 ` [PATCH 5/5] wcsmbs: " Carlos O'Donell
2023-05-18 16:06   ` Siddhesh Poyarekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9892ef99-434d-f420-3e36-efa17cf9a199@gotplt.org \
    --to=siddhesh@gotplt.org \
    --cc=carlos@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).