public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Carlos O'Donell <carlos@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH 3/5] stdio-common: Adjust tests in Makefile
Date: Thu, 18 May 2023 12:05:33 -0400	[thread overview]
Message-ID: <ca443f72-3d7b-1b4b-ed8a-f2fc0c086d45@gotplt.org> (raw)
In-Reply-To: <20230518130325.59309-4-carlos@redhat.com>



On 2023-05-18 09:03, Carlos O'Donell wrote:
> Sort tests against updated scripts/sort-makefile-lines.py.
> 
> No changes in generated code.
> No regressions on x86_64 and i686.
> ---

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

>   stdio-common/Makefile                  | 44 +++++++++++++-------------
>   stdio-common/{bug23-2.c => bug27.c}    |  0
>   stdio-common/{bug23-3.c => bug28.c}    |  0
>   stdio-common/{bug23-4.c => bug29.c}    |  0
>   stdio-common/{scanf14a.c => scanf18.c} |  0
>   stdio-common/{scanf16a.c => scanf19.c} |  0
>   6 files changed, 22 insertions(+), 22 deletions(-)
>   rename stdio-common/{bug23-2.c => bug27.c} (100%)
>   rename stdio-common/{bug23-3.c => bug28.c} (100%)
>   rename stdio-common/{bug23-4.c => bug29.c} (100%)
>   rename stdio-common/{scanf14a.c => scanf18.c} (100%)
>   rename stdio-common/{scanf16a.c => scanf19.c} (100%)
> 
> diff --git a/stdio-common/Makefile b/stdio-common/Makefile
> index 1b4997afc8..4c15b97683 100644
> --- a/stdio-common/Makefile
> +++ b/stdio-common/Makefile
> @@ -130,6 +130,13 @@ aux := \
>   tests := \
>     bug-vfprintf-nargs \
>     bug1 \
> +  bug3 \
> +  bug4 \
> +  bug5 \
> +  bug6 \
> +  bug7 \
> +  bug8 \
> +  bug9 \
>     bug10 \
>     bug11 \
>     bug12 \
> @@ -146,38 +153,31 @@ tests := \
>     bug21 \
>     bug22 \
>     bug23 \
> -  bug23-2 \
> -  bug23-3 \
> -  bug23-4 \
>     bug24 \
>     bug25 \
>     bug26 \
> -  bug3 \
> -  bug4 \
> -  bug5 \
> -  bug6 \
> -  bug7 \
> -  bug8 \
> -  bug9 \
> +  bug27 \
> +  bug28 \
> +  bug29 \
>     errnobug \
>     scanf1 \
> +  scanf2 \
> +  scanf3 \
> +  scanf4 \
> +  scanf5 \
> +  scanf7 \
> +  scanf8 \
> +  scanf9 \
>     scanf10 \
>     scanf11 \
>     scanf12 \
>     scanf13 \
>     scanf14 \
> -  scanf14a \
>     scanf15 \
>     scanf16 \
> -  scanf16a \
>     scanf17 \
> -  scanf2 \
> -  scanf3 \
> -  scanf4 \
> -  scanf5 \
> -  scanf7 \
> -  scanf8 \
> -  scanf9 \
> +  scanf18 \
> +  scanf19 \
>     temptest \
>     test-fseek \
>     test-fwrite \
> @@ -442,11 +442,11 @@ CFLAGS-isoc23_scanf.c += -fexceptions
>   
>   CFLAGS-dprintf.c += $(config-cflags-wno-ignored-attributes)
>   
> -# scanf14a.c and scanf16a.c test a deprecated extension which is no
> +# scanf18.c and scanf19.c test a deprecated extension which is no
>   # longer visible under most conformance levels; see the source files
>   # for more detail.
> -CFLAGS-scanf14a.c += -std=gnu89
> -CFLAGS-scanf16a.c += -std=gnu89
> +CFLAGS-scanf18.c += -std=gnu89
> +CFLAGS-scanf19.c += -std=gnu89
>   
>   CFLAGS-bug3.c += -DOBJPFX=\"$(objpfx)\"
>   CFLAGS-bug4.c += -DOBJPFX=\"$(objpfx)\"
> diff --git a/stdio-common/bug23-2.c b/stdio-common/bug27.c
> similarity index 100%
> rename from stdio-common/bug23-2.c
> rename to stdio-common/bug27.c
> diff --git a/stdio-common/bug23-3.c b/stdio-common/bug28.c
> similarity index 100%
> rename from stdio-common/bug23-3.c
> rename to stdio-common/bug28.c
> diff --git a/stdio-common/bug23-4.c b/stdio-common/bug29.c
> similarity index 100%
> rename from stdio-common/bug23-4.c
> rename to stdio-common/bug29.c
> diff --git a/stdio-common/scanf14a.c b/stdio-common/scanf18.c
> similarity index 100%
> rename from stdio-common/scanf14a.c
> rename to stdio-common/scanf18.c
> diff --git a/stdio-common/scanf16a.c b/stdio-common/scanf19.c
> similarity index 100%
> rename from stdio-common/scanf16a.c
> rename to stdio-common/scanf19.c

  reply	other threads:[~2023-05-18 16:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-18 13:03 [PATCH 0/5] Fix defect in sort-makefile-lines.py Carlos O'Donell
2023-05-18 13:03 ` [PATCH 1/5] scripts: sort-makefile-lines.py Carlos O'Donell
2023-05-18 15:56   ` Siddhesh Poyarekar
2023-05-18 16:53     ` Carlos O'Donell
2023-05-18 13:03 ` [PATCH 2/5] elf: Adjust tests in Makefile Carlos O'Donell
2023-05-18 16:05   ` Siddhesh Poyarekar
2023-05-18 13:03 ` [PATCH 3/5] stdio-common: " Carlos O'Donell
2023-05-18 16:05   ` Siddhesh Poyarekar [this message]
2023-05-18 13:03 ` [PATCH 4/5] misc: Reformat Makefile Carlos O'Donell
2023-05-18 16:06   ` Siddhesh Poyarekar
2023-05-18 13:03 ` [PATCH 5/5] wcsmbs: " Carlos O'Donell
2023-05-18 16:06   ` Siddhesh Poyarekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca443f72-3d7b-1b4b-ed8a-f2fc0c086d45@gotplt.org \
    --to=siddhesh@gotplt.org \
    --cc=carlos@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).