From: Peter Bergner <bergner@linux.ibm.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] powerpc: Remove power8 strcasestr optimization
Date: Fri, 15 Mar 2024 14:57:13 -0500 [thread overview]
Message-ID: <9e42c217-97ec-4e8f-93dd-17c432934697@linux.ibm.com> (raw)
In-Reply-To: <20240305201348.2470552-1-adhemerval.zanella@linaro.org>
I'm sorry I haven't replied earlier, but I just got back from vacation.
I also see you've pushed this already. That said...
As with the power7 patch, I'm all for cleanups, especially if they
simplify things, remove more code than they add, and make things
faster.
On 3/5/24 2:13 PM, Adhemerval Zanella wrote:
> Similar to strstr (1e9a550ba4), power8 strcasestr does not show much
> improvement compared to the generic implementation. The geomean
> on bench-strcasestr shows:
>
> __strcasestr_power8 __strcasestr_ppc
> power10 1159 1120
> power9 1640 1469
> power8 1787 1904
The generic implementation being the one in string/strcasestr.c,
correct? Then how do I read the performance numbers above?
When Raji first added the power8 optimized routine, it was
showing big speedups. I see that was before Wilco's changes
to the generic routine. Do you think that was the main
reason why the generic implementation is better now?
Even though it's already pushed...
LGTM.
Reviewed-by: Peter Bergner <bergner@linux.ibm.com>
Peter
next prev parent reply other threads:[~2024-03-15 19:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 20:13 Adhemerval Zanella
2024-03-12 2:37 ` DJ Delorie
2024-03-15 19:57 ` Peter Bergner [this message]
2024-03-18 12:52 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e42c217-97ec-4e8f-93dd-17c432934697@linux.ibm.com \
--to=bergner@linux.ibm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).