public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Joe Simmons-Talbott <josimmon@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2] elf/rtld: Count skipped environment variables for enable_secure
Date: Thu, 11 Apr 2024 12:57:28 -0400	[thread overview]
Message-ID: <CAAQBMsOiAHEp7yNHn5P+YBuFfXEk8=+PLoqTo_tAD_jsxKb05Q@mail.gmail.com> (raw)
In-Reply-To: <mvma5m09fn9.fsf@suse.de>

Thanks for your review.  I added a testcase to the v3[1] patch that
triggers the assert without the patch and does not trigger the assert
with the patch.  I'm not certain it's a useful test though since it's
essentially testing that the assertion isn't triggered.

Thanks,
Joe

[1] https://sourceware.org/pipermail/libc-alpha/2024-April/156034.html

On Thu, Apr 11, 2024 at 9:46 AM Andreas Schwab <schwab@suse.de> wrote:
>
> Can you please add a test?
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."
>


-- 
Joe Simmons-Talbott


      reply	other threads:[~2024-04-11 16:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07 21:40 Joe Simmons-Talbott
2024-04-10 19:58 ` Joe Simmons-Talbott
2024-04-11 13:45 ` Andreas Schwab
2024-04-11 16:57   ` Joe Simmons-Talbott [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAQBMsOiAHEp7yNHn5P+YBuFfXEk8=+PLoqTo_tAD_jsxKb05Q@mail.gmail.com' \
    --to=josimmon@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).