* [PATCH] x86: Fix an unknown vector operation in memchr-evex.S
@ 2021-05-08 1:23 Alice Xu
2021-05-08 1:32 ` H.J. Lu
0 siblings, 1 reply; 6+ messages in thread
From: Alice Xu @ 2021-05-08 1:23 UTC (permalink / raw)
To: libc-alpha
An unknown vector operation occurred in commit 2a76821c308. Fixed it
by using "ymm{k1}{z}" but not "ymm {k1} {z}".
---
sysdeps/x86_64/multiarch/memchr-evex.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sysdeps/x86_64/multiarch/memchr-evex.S
b/sysdeps/x86_64/multiarch/memchr-evex.S
index 81d5cd6486..f3fdad4fda 100644
--- a/sysdeps/x86_64/multiarch/memchr-evex.S
+++ b/sysdeps/x86_64/multiarch/memchr-evex.S
@@ -271,7 +271,7 @@ L(loop_4x_vec):
vpxorq (VEC_SIZE * 6)(%rdi), %YMMMATCH, %YMM3
VPCMP $0, (VEC_SIZE * 7)(%rdi), %YMMMATCH, %k3
/* Reduce VEC2 / VEC3 with min and VEC1 with zero mask. */
- VPMINU %YMM2, %YMM3, %YMM3 {%k1} {z}
+ VPMINU %YMM2, %YMM3, %YMM3{%k1}{z}
VPCMP $0, %YMM3, %YMMZERO, %k2
# ifdef USE_AS_RAWMEMCHR
subq $-(VEC_SIZE * 4), %rdi
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86: Fix an unknown vector operation in memchr-evex.S
2021-05-08 1:23 [PATCH] x86: Fix an unknown vector operation in memchr-evex.S Alice Xu
@ 2021-05-08 1:32 ` H.J. Lu
2021-05-08 1:55 ` Alice Xu
0 siblings, 1 reply; 6+ messages in thread
From: H.J. Lu @ 2021-05-08 1:32 UTC (permalink / raw)
To: Alice Xu; +Cc: GNU C Library
On Fri, May 7, 2021 at 6:23 PM Alice Xu <alice.d.xu@gmail.com> wrote:
>
> An unknown vector operation occurred in commit 2a76821c308. Fixed it
> by using "ymm{k1}{z}" but not "ymm {k1} {z}".
>
> ---
> sysdeps/x86_64/multiarch/memchr-evex.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86_64/multiarch/memchr-evex.S b/sysdeps/x86_64/multiarch/memchr-evex.S
> index 81d5cd6486..f3fdad4fda 100644
> --- a/sysdeps/x86_64/multiarch/memchr-evex.S
> +++ b/sysdeps/x86_64/multiarch/memchr-evex.S
> @@ -271,7 +271,7 @@ L(loop_4x_vec):
> vpxorq (VEC_SIZE * 6)(%rdi), %YMMMATCH, %YMM3
> VPCMP $0, (VEC_SIZE * 7)(%rdi), %YMMMATCH, %k3
> /* Reduce VEC2 / VEC3 with min and VEC1 with zero mask. */
> - VPMINU %YMM2, %YMM3, %YMM3 {%k1} {z}
> + VPMINU %YMM2, %YMM3, %YMM3{%k1}{z}
> VPCMP $0, %YMM3, %YMMZERO, %k2
> # ifdef USE_AS_RAWMEMCHR
> subq $-(VEC_SIZE * 4), %rdi
> --
> 2.25.1
LGTM.
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
Do you want me to commit it for you?
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86: Fix an unknown vector operation in memchr-evex.S
2021-05-08 1:32 ` H.J. Lu
@ 2021-05-08 1:55 ` Alice Xu
2021-05-08 2:00 ` H.J. Lu
0 siblings, 1 reply; 6+ messages in thread
From: Alice Xu @ 2021-05-08 1:55 UTC (permalink / raw)
To: H.J. Lu; +Cc: GNU C Library
Yes, please help to commit it. Thanks.
Regards
Alice
On Sat, May 8, 2021 at 9:32 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, May 7, 2021 at 6:23 PM Alice Xu <alice.d.xu@gmail.com> wrote:
> >
> > An unknown vector operation occurred in commit 2a76821c308. Fixed it
> > by using "ymm{k1}{z}" but not "ymm {k1} {z}".
> >
> > ---
> > sysdeps/x86_64/multiarch/memchr-evex.S | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sysdeps/x86_64/multiarch/memchr-evex.S
> b/sysdeps/x86_64/multiarch/memchr-evex.S
> > index 81d5cd6486..f3fdad4fda 100644
> > --- a/sysdeps/x86_64/multiarch/memchr-evex.S
> > +++ b/sysdeps/x86_64/multiarch/memchr-evex.S
> > @@ -271,7 +271,7 @@ L(loop_4x_vec):
> > vpxorq (VEC_SIZE * 6)(%rdi), %YMMMATCH, %YMM3
> > VPCMP $0, (VEC_SIZE * 7)(%rdi), %YMMMATCH, %k3
> > /* Reduce VEC2 / VEC3 with min and VEC1 with zero mask. */
> > - VPMINU %YMM2, %YMM3, %YMM3 {%k1} {z}
> > + VPMINU %YMM2, %YMM3, %YMM3{%k1}{z}
> > VPCMP $0, %YMM3, %YMMZERO, %k2
> > # ifdef USE_AS_RAWMEMCHR
> > subq $-(VEC_SIZE * 4), %rdi
> > --
> > 2.25.1
>
> LGTM.
>
> Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
>
> Do you want me to commit it for you?
>
> Thanks.
>
> --
> H.J.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86: Fix an unknown vector operation in memchr-evex.S
2021-05-08 1:55 ` Alice Xu
@ 2021-05-08 2:00 ` H.J. Lu
2021-05-08 2:34 ` H.J. Lu
0 siblings, 1 reply; 6+ messages in thread
From: H.J. Lu @ 2021-05-08 2:00 UTC (permalink / raw)
To: Alice Xu; +Cc: GNU C Library
On Fri, May 7, 2021 at 6:55 PM Alice Xu <alice.d.xu@gmail.com> wrote:
>
> Yes, please help to commit it. Thanks.
I will commit it for you. Next time, please use "git format-patch" to create
patches.
> Regards
>
> Alice
>
> On Sat, May 8, 2021 at 9:32 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>>
>> On Fri, May 7, 2021 at 6:23 PM Alice Xu <alice.d.xu@gmail.com> wrote:
>> >
>> > An unknown vector operation occurred in commit 2a76821c308. Fixed it
>> > by using "ymm{k1}{z}" but not "ymm {k1} {z}".
>> >
>> > ---
>> > sysdeps/x86_64/multiarch/memchr-evex.S | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/sysdeps/x86_64/multiarch/memchr-evex.S b/sysdeps/x86_64/multiarch/memchr-evex.S
>> > index 81d5cd6486..f3fdad4fda 100644
>> > --- a/sysdeps/x86_64/multiarch/memchr-evex.S
>> > +++ b/sysdeps/x86_64/multiarch/memchr-evex.S
>> > @@ -271,7 +271,7 @@ L(loop_4x_vec):
>> > vpxorq (VEC_SIZE * 6)(%rdi), %YMMMATCH, %YMM3
>> > VPCMP $0, (VEC_SIZE * 7)(%rdi), %YMMMATCH, %k3
>> > /* Reduce VEC2 / VEC3 with min and VEC1 with zero mask. */
>> > - VPMINU %YMM2, %YMM3, %YMM3 {%k1} {z}
>> > + VPMINU %YMM2, %YMM3, %YMM3{%k1}{z}
>> > VPCMP $0, %YMM3, %YMMZERO, %k2
>> > # ifdef USE_AS_RAWMEMCHR
>> > subq $-(VEC_SIZE * 4), %rdi
>> > --
>> > 2.25.1
>>
>> LGTM.
>>
>> Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
>>
>> Do you want me to commit it for you?
>>
>> Thanks.
>>
>> --
>> H.J.
--
H.J.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86: Fix an unknown vector operation in memchr-evex.S
2021-05-08 2:00 ` H.J. Lu
@ 2021-05-08 2:34 ` H.J. Lu
2021-05-08 3:17 ` Alice Xu
0 siblings, 1 reply; 6+ messages in thread
From: H.J. Lu @ 2021-05-08 2:34 UTC (permalink / raw)
To: Alice Xu; +Cc: GNU C Library
[-- Attachment #1: Type: text/plain, Size: 374 bytes --]
On Fri, May 7, 2021 at 7:00 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Fri, May 7, 2021 at 6:55 PM Alice Xu <alice.d.xu@gmail.com> wrote:
> >
> > Yes, please help to commit it. Thanks.
>
> I will commit it for you. Next time, please use "git format-patch" to create
> patches.
>
This is the patch I am checking in for you after fixing indentation and
space.
--
H.J.
[-- Attachment #2: 0001-x86-64-Fix-an-unknown-vector-operation-in-memchr-eve.patch --]
[-- Type: text/x-patch, Size: 1070 bytes --]
From 6ea916adfa0ab9af6e7dc6adcf6f977dfe017835 Mon Sep 17 00:00:00 2001
From: Alice Xu <alice.d.xu@gmail.com>
Date: Fri, 7 May 2021 19:03:21 -0700
Subject: [PATCH] x86-64: Fix an unknown vector operation in memchr-evex.S
An unknown vector operation occurred in commit 2a76821c308. Fixed it
by using "ymm{k1}{z}" but not "ymm {k1} {z}".
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
---
sysdeps/x86_64/multiarch/memchr-evex.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sysdeps/x86_64/multiarch/memchr-evex.S b/sysdeps/x86_64/multiarch/memchr-evex.S
index 81d5cd6486..f3fdad4fda 100644
--- a/sysdeps/x86_64/multiarch/memchr-evex.S
+++ b/sysdeps/x86_64/multiarch/memchr-evex.S
@@ -271,7 +271,7 @@ L(loop_4x_vec):
vpxorq (VEC_SIZE * 6)(%rdi), %YMMMATCH, %YMM3
VPCMP $0, (VEC_SIZE * 7)(%rdi), %YMMMATCH, %k3
/* Reduce VEC2 / VEC3 with min and VEC1 with zero mask. */
- VPMINU %YMM2, %YMM3, %YMM3 {%k1} {z}
+ VPMINU %YMM2, %YMM3, %YMM3{%k1}{z}
VPCMP $0, %YMM3, %YMMZERO, %k2
# ifdef USE_AS_RAWMEMCHR
subq $-(VEC_SIZE * 4), %rdi
--
2.31.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86: Fix an unknown vector operation in memchr-evex.S
2021-05-08 2:34 ` H.J. Lu
@ 2021-05-08 3:17 ` Alice Xu
0 siblings, 0 replies; 6+ messages in thread
From: Alice Xu @ 2021-05-08 3:17 UTC (permalink / raw)
To: H.J. Lu; +Cc: GNU C Library
Thanks. I used " git format-patch ", but when I used git send-email to
send the patch, I got an SMTP server error, so I use my web Gmail to send
it. Next time I'll attach the patch file inner mail.
Thanks a lot.
Regards
Alice.
On Sat, May 8, 2021 at 10:35 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, May 7, 2021 at 7:00 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Fri, May 7, 2021 at 6:55 PM Alice Xu <alice.d.xu@gmail.com> wrote:
> > >
> > > Yes, please help to commit it. Thanks.
> >
> > I will commit it for you. Next time, please use "git format-patch" to
> create
> > patches.
> >
>
> This is the patch I am checking in for you after fixing indentation and
> space.
>
> --
> H.J.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-08 3:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-08 1:23 [PATCH] x86: Fix an unknown vector operation in memchr-evex.S Alice Xu
2021-05-08 1:32 ` H.J. Lu
2021-05-08 1:55 ` Alice Xu
2021-05-08 2:00 ` H.J. Lu
2021-05-08 2:34 ` H.J. Lu
2021-05-08 3:17 ` Alice Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).