From: Fergus Dall <sidereal@google.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: Fergus Dall via Libc-alpha <libc-alpha@sourceware.org>,
Mike Frysinger <vapier@google.com>,
clumptini <clumptini@google.com>,
chromeos-toolchain@google.com
Subject: Re: [PATCH v2 1/2] rtld: Add --no-default-paths option
Date: Mon, 7 Jun 2021 02:27:03 +1000 [thread overview]
Message-ID: <CAAjxMxet67Gyuy4XsOc+XEt1=yO=3ATQHHPfFbQ=q-te2SGzjw@mail.gmail.com> (raw)
In-Reply-To: <87mtsgmcy2.fsf@oldenburg.str.redhat.com>
None of the other options in that file use "bool" even when they seem
to only be used as booleans. I assumed this was out of a desire to
keep C89 compatibility, though now that I look I see lots of other
places in the codebase that don't do that.
On Fri, May 28, 2021 at 1:08 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * Fergus Dall via Libc-alpha:
>
> > diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h
> > index e383aa1dc3..f9f2c4126a 100644
> > --- a/sysdeps/generic/ldsodefs.h
> > +++ b/sysdeps/generic/ldsodefs.h
> > @@ -551,6 +551,9 @@ struct rtld_global_ro
> > /* Do we read from ld.so.cache? */
> > EXTERN int _dl_inhibit_cache;
> >
> > + /* Do we search the default system paths? */
> > + EXTERN int _dl_search_default_paths;
>
> Maybe use a bool for this?
>
> Thanks,
> Florian
>
prev parent reply other threads:[~2021-06-06 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 13:55 Fergus Dall
2021-05-27 13:56 ` [PATCH v2 2/2] rtld: Add tests for new " Fergus Dall
2021-05-27 16:36 ` Joseph Myers
2021-05-27 15:08 ` [PATCH v2 1/2] rtld: Add " Florian Weimer
2021-06-06 16:27 ` Fergus Dall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAjxMxet67Gyuy4XsOc+XEt1=yO=3ATQHHPfFbQ=q-te2SGzjw@mail.gmail.com' \
--to=sidereal@google.com \
--cc=chromeos-toolchain@google.com \
--cc=clumptini@google.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=vapier@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).