public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Godmar Back <godmar@gmail.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 2/2] posix: Add terminal control setting support for posix_spawn
Date: Tue, 29 Jun 2021 15:35:45 -0400	[thread overview]
Message-ID: <CAB4+JYKSAkJ+r+1p4Dm4KYwergmipo8OOGCwc9h57KBFbyJ0Pw@mail.gmail.com> (raw)
In-Reply-To: <00bab39b-c5d9-25aa-67cf-3d8adedda8e1@linaro.org>

On Tue, Jun 29, 2021 at 1:03 PM Adhemerval Zanella <
adhemerval.zanella@linaro.org> wrote:

>
> OK, I completely forgot that we explicit block *all* signals (including
> internals ones) on the helper process to avoid any signal handler (I had
> to debug the kernel to remind it):  (...)
>
SO there is no need to handle SIGTTOU here and we already either set the
> expected mask or restore the previous defined one just before execve.
>

Yeah! So it should work.

One other thought that occurred to me is that the test program could check
that getpgid(getppid()) != getpgrp() to make sure that a new pgrp was
actually created.

I would love to start using this code before this fix hits the next
release. To that end, I'll plan on
carving out the corresponding files from the GNU libc source code and place
them earlier on the link command line so that they'll get picked up by the
linker in lieu of the libc equivalent.
I hope this will work.

  reply	other threads:[~2021-06-29 19:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 17:57 [PATCH 1/2] posix: Remove spawni.c Adhemerval Zanella
2021-06-17 17:57 ` [PATCH 2/2] posix: Add terminal control setting support for posix_spawn Adhemerval Zanella
2021-06-17 18:15   ` Andreas Schwab
2021-06-28 20:10     ` Adhemerval Zanella
2021-06-28  1:11   ` Godmar Back
2021-06-28 22:03     ` Adhemerval Zanella
2021-06-28 22:17       ` Godmar Back
2021-06-29  8:12         ` Andreas Schwab
2021-06-29 17:03         ` Adhemerval Zanella
2021-06-29 19:35           ` Godmar Back [this message]
2021-06-28 22:01   ` Godmar Back

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAB4+JYKSAkJ+r+1p4Dm4KYwergmipo8OOGCwc9h57KBFbyJ0Pw@mail.gmail.com \
    --to=godmar@gmail.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).