From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Andreas Schwab <schwab@linux-m68k.org>,
Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Cc: Godmar Back <godmar@gmail.com>
Subject: Re: [PATCH 2/2] posix: Add terminal control setting support for posix_spawn
Date: Mon, 28 Jun 2021 17:10:27 -0300 [thread overview]
Message-ID: <f0b74a62-a2f5-0506-e59a-7e7ad636e492@linaro.org> (raw)
In-Reply-To: <8735tgmk79.fsf@igel.home>
On 17/06/2021 15:15, Andreas Schwab wrote:
> On Jun 17 2021, Adhemerval Zanella via Libc-alpha wrote:
>
>> @@ -166,6 +168,18 @@ extern int posix_spawnattr_setschedparam (posix_spawnattr_t *__restrict __attr,
>> __restrict __schedparam)
>> __THROW __nonnull ((1, 2));
>>
>> +#ifdef __USE_GNU
>> +/* Make the spawned process the foreground process group on the terminal
>> + associated with FD (which must be a controlling terminal, and still be
>> + associated with its section. */
>
> Missing close paren. Did you mean session?
>
> Andreas.
>
Ack and I did mean session, I fixed both thanks.
next prev parent reply other threads:[~2021-06-28 20:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 17:57 [PATCH 1/2] posix: Remove spawni.c Adhemerval Zanella
2021-06-17 17:57 ` [PATCH 2/2] posix: Add terminal control setting support for posix_spawn Adhemerval Zanella
2021-06-17 18:15 ` Andreas Schwab
2021-06-28 20:10 ` Adhemerval Zanella [this message]
2021-06-28 1:11 ` Godmar Back
2021-06-28 22:03 ` Adhemerval Zanella
2021-06-28 22:17 ` Godmar Back
2021-06-29 8:12 ` Andreas Schwab
2021-06-29 17:03 ` Adhemerval Zanella
2021-06-29 19:35 ` Godmar Back
2021-06-28 22:01 ` Godmar Back
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0b74a62-a2f5-0506-e59a-7e7ad636e492@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=godmar@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).