From: Keno Fischer <keno@juliacomputing.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Add CFI to x86_64 RTLD_START
Date: Fri, 08 Jul 2016 20:46:00 -0000 [thread overview]
Message-ID: <CABV8kRy7G3nGF7YBePHb9QzKQWM-oo9Bw1hQFjR8EfNwbtv33w@mail.gmail.com> (raw)
In-Reply-To: <87inwlqjn6.fsf@linux-m68k.org>
Might it make sense to change the macro to clearly
separate the string literals and the backslashes, i.e.
".globl _start\n" \
".globl _dl_start_user\n" \
"_start:\n" \
etc.?
On Mon, Jul 4, 2016 at 3:37 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Keno Fischer <keno@juliacomputing.com> writes:
>
>> I should have probably sent this patch with more diff context, but
>> since this is part of a preprocessor `#define`, the backslashes are
>> still required, no?
>
> Yes, sorry, I missed that. But please put a space before the
> backslashes outside of the string literals.
>
> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
next prev parent reply other threads:[~2016-07-08 20:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 17:39 Keno Fischer
2016-07-04 18:23 ` Andreas Schwab
2016-07-04 18:28 ` Keno Fischer
2016-07-04 19:38 ` Andreas Schwab
2016-07-08 20:46 ` Keno Fischer [this message]
[not found] ` <CABV8kRwpe3k49Kk5bA-cfsF9vPj6y_1sSe_dWk8F3sTtkeDPGA@mail.gmail.com>
2016-08-02 3:27 ` Keno Fischer
2016-08-11 19:39 ` Keno Fischer
2016-11-01 20:49 ` Keno Fischer
2016-11-07 16:44 ` H.J. Lu
2016-11-16 3:52 ` Keno Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABV8kRy7G3nGF7YBePHb9QzKQWM-oo9Bw1hQFjR8EfNwbtv33w@mail.gmail.com \
--to=keno@juliacomputing.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).