public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Noah Goldstein <goldstein.w.n@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
	"Carlos O'Donell" <carlos@systemhalted.org>
Subject: Re: [PATCH v1] x86: Set .text section in memset-vec-unaligned-erms
Date: Sat, 12 Feb 2022 15:44:33 -0600	[thread overview]
Message-ID: <CAFUsyf+1n23T61OP=miV0N=x_XfaL7XD0HL5aLoi9=D5fvw1bg@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOq8mXuHvTLnpa_awhm5Cr_qDNg9YQNsis0RTQ7cgY3bKA@mail.gmail.com>

On Sat, Feb 12, 2022 at 9:47 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Sat, Feb 12, 2022 at 2:25 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > commit 3d9f171bfb5325bd5f427e9fc386453358c6e840
> > Author: H.J. Lu <hjl.tools@gmail.com>
> > Date:   Mon Feb 7 05:55:15 2022 -0800
> >
> >     x86-64: Optimize bzero
> >
> > Remove setting the .text section for the code. This commit
> > adds that back.
> > ---
> >  sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> > index 7c94fcdae1..785fee1d57 100644
> > --- a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> > +++ b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> > @@ -114,6 +114,7 @@
> >  # error SECTION is not defined!
> >  #endif
> >
> > +       .section SECTION(.text), "ax", @progbits
> >  #if IS_IN (libc)
> >  # if defined SHARED
> >  ENTRY_CHK (WMEMSET_CHK_SYMBOL (__wmemset_chk, unaligned))
> > --
> > 2.25.1
> >
>
> LGTM.
>
> Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
>
> Thanks.
>

Thanks pushed.
> --
> H.J.

  reply	other threads:[~2022-02-12 21:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-12 10:25 Noah Goldstein
2022-02-12 15:46 ` H.J. Lu
2022-02-12 21:44   ` Noah Goldstein [this message]
2022-05-04  6:01     ` Sunil Pandey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFUsyf+1n23T61OP=miV0N=x_XfaL7XD0HL5aLoi9=D5fvw1bg@mail.gmail.com' \
    --to=goldstein.w.n@gmail.com \
    --cc=carlos@systemhalted.org \
    --cc=hjl.tools@gmail.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).