Re: [PATCH] build: All microbenchmarks should output in JSON. (bug 27740)

[Noah Goldstein <goldstein.w.n@gmail.com>]

On Sun, Mar 5, 2023 at 12:15 AM Girish Joshi via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Ping.
>
> Girish Joshi
>
>
> On Sun, Feb 19, 2023 at 6:20 PM Girish Joshi <girish946@gmail.com> wrote:
> >
> > Hello,
> > According to bug #27740 [1], I found that the following files need to
> > be updated.
> >
> >     - benchtests/bench-memccpy.c
> >     - benchtests/bench-strcasestr.c
> >     - benchtests/bench-strcpy_chk.c
> >     - benchtests/bench-strsep.c
> >     - benchtests/bench-strtok.c
> >
> > Also, the output json needs to be fixed in two files.
> >     - bench-math-inlines.c
> >     - bench-strcoll.c
> >
> > This patch fixes both of these things.
> > The output is tested using
> > benchtests/scripts/compare_strings.py.
> >
> > Please let me know if some correction is needed in this patch.

When applying:
```
Applying: build: All microbenchmarks should output in JSON. (bug 27740)
.git/rebase-apply/patch:235: trailing whitespace.
    json_element_string(&json_ctx, impl->name);
warning: 1 line adds whitespace errors.
```

Also can you please post the patch as inline text in the email? It
allows patchwork
to detect it and easier to inline comments during review.

Some general feedback:
1) The changes to `benchtests/bench-math-inlines.c`/`benchtests/bench-strcoll.c`
seem unrelated, can you make that a seperate patch.
2) You are missing some test parameters in most of the files (mostly `max_char`)
also `dlen` in `bench_strcpy_chk.c`. Can you make sure you get all of them that
are relevant to the input.

> >
> > Thanks,
> > Girish Joshi
> > girishjoshi.io
> >
> > [1]: https://sourceware.org/bugzilla/show_bug.cgi?id=27740