* [PATCH] benchtests: Use "=" instead of ":=" [BZ #28970]
@ 2022-03-16 15:43 H.J. Lu
2022-03-16 15:46 ` Sunil Pandey
2022-03-16 15:47 ` Noah Goldstein
0 siblings, 2 replies; 3+ messages in thread
From: H.J. Lu @ 2022-03-16 15:43 UTC (permalink / raw)
To: libc-alpha
Use "=" instead of ":=" to allow sysdeps Makefiles to add more benches
to bench and benchset. This fixes BZ #28970.
---
benchtests/Makefile | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/benchtests/Makefile b/benchtests/Makefile
index d513b29903..8dfca592fd 100644
--- a/benchtests/Makefile
+++ b/benchtests/Makefile
@@ -296,9 +296,11 @@ bench-extra-objs = json-lib.o
extra-objs += $(bench-extra-objs)
others-extras = $(bench-extra-objs)
-binaries-bench := $(addprefix $(objpfx)bench-,$(bench))
+# NB: Use "=" instead of ":=" since sysdeps Makefiles may add more
+# benches.
+binaries-bench = $(addprefix $(objpfx)bench-,$(bench))
extra-objs += $(addsuffix .o,$(addprefix bench-,$(bench)))
-binaries-benchset := $(addprefix $(objpfx)bench-,$(benchset))
+binaries-benchset = $(addprefix $(objpfx)bench-,$(benchset))
extra-objs += $(addsuffix .o,$(addprefix bench-,$(benchset)))
binaries-bench-malloc := $(addprefix $(objpfx)bench-,$(bench-malloc))
extra-objs += $(addsuffix .o,$(addprefix bench-,$(bench-malloc)))
--
2.35.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] benchtests: Use "=" instead of ":=" [BZ #28970]
2022-03-16 15:43 [PATCH] benchtests: Use "=" instead of ":=" [BZ #28970] H.J. Lu
@ 2022-03-16 15:46 ` Sunil Pandey
2022-03-16 15:47 ` Noah Goldstein
1 sibling, 0 replies; 3+ messages in thread
From: Sunil Pandey @ 2022-03-16 15:46 UTC (permalink / raw)
To: H.J. Lu; +Cc: GNU C Library
On Wed, Mar 16, 2022 at 8:44 AM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Use "=" instead of ":=" to allow sysdeps Makefiles to add more benches
> to bench and benchset. This fixes BZ #28970.
> ---
> benchtests/Makefile | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/benchtests/Makefile b/benchtests/Makefile
> index d513b29903..8dfca592fd 100644
> --- a/benchtests/Makefile
> +++ b/benchtests/Makefile
> @@ -296,9 +296,11 @@ bench-extra-objs = json-lib.o
> extra-objs += $(bench-extra-objs)
> others-extras = $(bench-extra-objs)
>
> -binaries-bench := $(addprefix $(objpfx)bench-,$(bench))
> +# NB: Use "=" instead of ":=" since sysdeps Makefiles may add more
> +# benches.
> +binaries-bench = $(addprefix $(objpfx)bench-,$(bench))
> extra-objs += $(addsuffix .o,$(addprefix bench-,$(bench)))
> -binaries-benchset := $(addprefix $(objpfx)bench-,$(benchset))
> +binaries-benchset = $(addprefix $(objpfx)bench-,$(benchset))
> extra-objs += $(addsuffix .o,$(addprefix bench-,$(benchset)))
> binaries-bench-malloc := $(addprefix $(objpfx)bench-,$(bench-malloc))
> extra-objs += $(addsuffix .o,$(addprefix bench-,$(bench-malloc)))
> --
> 2.35.1
>
LGTM
Reviewed-by: Sunil K Pandey <skpgkp2@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] benchtests: Use "=" instead of ":=" [BZ #28970]
2022-03-16 15:43 [PATCH] benchtests: Use "=" instead of ":=" [BZ #28970] H.J. Lu
2022-03-16 15:46 ` Sunil Pandey
@ 2022-03-16 15:47 ` Noah Goldstein
1 sibling, 0 replies; 3+ messages in thread
From: Noah Goldstein @ 2022-03-16 15:47 UTC (permalink / raw)
To: H.J. Lu; +Cc: GNU C Library
On Wed, Mar 16, 2022 at 10:43 AM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Use "=" instead of ":=" to allow sysdeps Makefiles to add more benches
> to bench and benchset. This fixes BZ #28970.
> ---
> benchtests/Makefile | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/benchtests/Makefile b/benchtests/Makefile
> index d513b29903..8dfca592fd 100644
> --- a/benchtests/Makefile
> +++ b/benchtests/Makefile
> @@ -296,9 +296,11 @@ bench-extra-objs = json-lib.o
> extra-objs += $(bench-extra-objs)
> others-extras = $(bench-extra-objs)
>
> -binaries-bench := $(addprefix $(objpfx)bench-,$(bench))
> +# NB: Use "=" instead of ":=" since sysdeps Makefiles may add more
> +# benches.
> +binaries-bench = $(addprefix $(objpfx)bench-,$(bench))
> extra-objs += $(addsuffix .o,$(addprefix bench-,$(bench)))
> -binaries-benchset := $(addprefix $(objpfx)bench-,$(benchset))
> +binaries-benchset = $(addprefix $(objpfx)bench-,$(benchset))
> extra-objs += $(addsuffix .o,$(addprefix bench-,$(benchset)))
> binaries-bench-malloc := $(addprefix $(objpfx)bench-,$(bench-malloc))
> extra-objs += $(addsuffix .o,$(addprefix bench-,$(bench-malloc)))
> --
> 2.35.1
>
LGTM.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-16 15:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-16 15:43 [PATCH] benchtests: Use "=" instead of ":=" [BZ #28970] H.J. Lu
2022-03-16 15:46 ` Sunil Pandey
2022-03-16 15:47 ` Noah Goldstein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).