Re: [PATCH] test-memcpy.c: Double TIMEOUT to (8 * 60)

[Noah Goldstein <goldstein.w.n@gmail.com>]

On Sun, Nov 7, 2021 at 10:08 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> commit d585ba47fcda99fdf228e3e45a01b11a15efbc5a
> Author: Noah Goldstein <goldstein.w.n@gmail.com>
> Date:   Mon Nov 1 00:49:48 2021 -0500
>
>     string: Make tests birdirectional test-memcpy.c
>
>     This commit updates the memcpy tests to test both dst > src and dst <
>     src. This is because there is logic in the code based on the
>
>     Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
>     Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
>
> significantly increased the number of tests.  On Intel Core i7-1165G7,
> test-memcpy takes 120 seconds to run when machine is idle.  Double
> TIMEOUT to (8 * 60) for test-memcpy to avoid timeout when machine is
> under heavy load.
> ---
>  string/test-memcpy.c | 1 +
>  string/test-string.h | 4 +++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/string/test-memcpy.c b/string/test-memcpy.c
> index 3b0f3127b7..101d51c487 100644
> --- a/string/test-memcpy.c
> +++ b/string/test-memcpy.c
> @@ -22,6 +22,7 @@
>  # define MIN_PAGE_SIZE 131072
>  # define TEST_MAIN
>  # define TEST_NAME "memcpy"
> +# define TIMEOUT (8 * 60)
>  # include "test-string.h"
>
>  char *simple_memcpy (char *, const char *, size_t);
> diff --git a/string/test-string.h b/string/test-string.h
> index 8ee00a04b1..9a6b76daa4 100644
> --- a/string/test-string.h
> +++ b/string/test-string.h
> @@ -68,7 +68,9 @@ extern impl_t __start_impls[], __stop_impls[];
>
>
>  # define TEST_FUNCTION test_main
> -# define TIMEOUT (4 * 60)
> +# ifndef TIMEOUT
> +#  define TIMEOUT (4 * 60)
> +# endif
>  # define OPT_ITERATIONS 10000
>  # define OPT_RANDOM 10001
>  # define OPT_SEED 10002
> --
> 2.33.1
>

LGTM