From: "H.J. Lu" <hjl.tools@gmail.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] test-memcpy.c: Double TIMEOUT to (8 * 60)
Date: Mon, 8 Nov 2021 05:13:19 -0800 [thread overview]
Message-ID: <CAMe9rOoVu6_s_gKWwnXmxLrrFFYvfN2FYbJY4JWfZ9VgDeMn_Q@mail.gmail.com> (raw)
In-Reply-To: <2e15794f-555c-30f1-f774-f23839146da6@linaro.org>
On Mon, Nov 8, 2021 at 3:39 AM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
>
>
> On 07/11/2021 13:08, H.J. Lu via Libc-alpha wrote:
> > commit d585ba47fcda99fdf228e3e45a01b11a15efbc5a
> > Author: Noah Goldstein <goldstein.w.n@gmail.com>
> > Date: Mon Nov 1 00:49:48 2021 -0500
> >
> > string: Make tests birdirectional test-memcpy.c
> >
> > This commit updates the memcpy tests to test both dst > src and dst <
> > src. This is because there is logic in the code based on the
> >
> > Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
> > Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
> >
> > significantly increased the number of tests. On Intel Core i7-1165G7,
> > test-memcpy takes 120 seconds to run when machine is idle. Double
> > TIMEOUT to (8 * 60) for test-memcpy to avoid timeout when machine is
> > under heavy load.
>
> Shouldn't we split the test instead? If it takes 120s on a high-end chip,
> it might take way more in other chips. It also optimizes the testsuite,
> since it would allow to better use parallel builds.
This sounds like a good idea. Noah, can you do that?
Thanks.
> > ---
> > string/test-memcpy.c | 1 +
> > string/test-string.h | 4 +++-
> > 2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/string/test-memcpy.c b/string/test-memcpy.c
> > index 3b0f3127b7..101d51c487 100644
> > --- a/string/test-memcpy.c
> > +++ b/string/test-memcpy.c
> > @@ -22,6 +22,7 @@
> > # define MIN_PAGE_SIZE 131072
> > # define TEST_MAIN
> > # define TEST_NAME "memcpy"
> > +# define TIMEOUT (8 * 60)
> > # include "test-string.h"
> >
> > char *simple_memcpy (char *, const char *, size_t);
> > diff --git a/string/test-string.h b/string/test-string.h
> > index 8ee00a04b1..9a6b76daa4 100644
> > --- a/string/test-string.h
> > +++ b/string/test-string.h
> > @@ -68,7 +68,9 @@ extern impl_t __start_impls[], __stop_impls[];
> >
> >
> > # define TEST_FUNCTION test_main
> > -# define TIMEOUT (4 * 60)
> > +# ifndef TIMEOUT
> > +# define TIMEOUT (4 * 60)
> > +# endif
> > # define OPT_ITERATIONS 10000
> > # define OPT_RANDOM 10001
> > # define OPT_SEED 10002
> >
--
H.J.
next prev parent reply other threads:[~2021-11-08 13:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-07 16:08 H.J. Lu
2021-11-07 17:40 ` Noah Goldstein
2021-11-08 11:39 ` Adhemerval Zanella
2021-11-08 13:13 ` H.J. Lu [this message]
2021-11-08 14:02 ` Noah Goldstein
2021-11-08 19:43 ` Noah Goldstein
2021-11-08 19:46 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOoVu6_s_gKWwnXmxLrrFFYvfN2FYbJY4JWfZ9VgDeMn_Q@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).