From: Noah Goldstein <goldstein.w.n@gmail.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3 1/3] x86: Optimize memcmp SSE2 in memcmp.S
Date: Tue, 19 Apr 2022 17:56:13 -0500 [thread overview]
Message-ID: <CAFUsyfLOTir+QsJOnhmQiU1n7jw4NP8=TrAecgMbww5HEFG=-g@mail.gmail.com> (raw)
In-Reply-To: <CAFUsyfJt_HOQ1msmj_xSfAYm_7jB-XZg-7jNepXSD-Xd7Ui2nw@mail.gmail.com>
On Tue, Apr 19, 2022 at 3:53 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> On Tue, Apr 19, 2022 at 3:30 PM Joseph Myers <joseph@codesourcery.com> wrote:
> >
> > A recent commit, probably this one, broke the build for x86_64-linux-gnu
> > --disable-multi-arch.
> >
> > /scratch/jmyers/glibc-bot/install/compilers/x86_64-linux-gnu/lib/gcc/x86_64-glibc-linux-gnu/11.2.1/../../../../x86_64-glibc-linux-gnu/bin/ld: /scratch/jmyers/glibc-bot/build/glibcs/x86_64-linux-gnu-minimal/glibc/libc_pic.os: in function `internal_fnwmatch':
> > /scratch/jmyers/glibc-bot/src/glibc/posix/fnmatch_loop.c:513: undefined reference to `__wmemcmp'
> > /scratch/jmyers/glibc-bot/install/compilers/x86_64-linux-gnu/lib/gcc/x86_64-glibc-linux-gnu/11.2.1/../../../../x86_64-glibc-linux-gnu/bin/ld: /scratch/jmyers/glibc-bot/src/glibc/posix/fnmatch_loop.c:536: undefined reference to `__wmemcmp'
> > /scratch/jmyers/glibc-bot/install/compilers/x86_64-linux-gnu/lib/gcc/x86_64-glibc-linux-gnu/11.2.1/../../../../x86_64-glibc-linux-gnu/bin/ld: /scratch/jmyers/glibc-bot/src/glibc/posix/fnmatch_loop.c:704: undefined reference to `__wmemcmp'
> >
> > https://sourceware.org/pipermail/libc-testresults/2022q2/009576.html
>
> Reproduced issue, think have fix. Testing it now.
Posted a patch.
> >
> > --
> > Joseph S. Myers
> > joseph@codesourcery.com
next prev parent reply other threads:[~2022-04-19 22:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 5:51 [PATCH v1 " Noah Goldstein
2022-04-15 5:51 ` [PATCH v1 2/3] x86: Remove memcmp-sse4.S Noah Goldstein
2022-04-15 17:20 ` H.J. Lu
2022-04-15 17:29 ` Noah Goldstein
2022-04-15 5:51 ` [PATCH v1 3/3] x86: Cleanup page cross code in memcmp-avx2-movbe.S Noah Goldstein
2022-04-15 17:21 ` H.J. Lu
2022-04-15 17:13 ` [PATCH v1 1/3] x86: Optimize memcmp SSE2 in memcmp.S H.J. Lu
2022-04-15 17:25 ` [PATCH v2 " Noah Goldstein
2022-04-15 17:25 ` [PATCH v2 2/3] x86: Remove memcmp-sse4.S Noah Goldstein
2022-04-15 17:25 ` [PATCH v2 3/3] x86: Cleanup page cross code in memcmp-avx2-movbe.S Noah Goldstein
2022-04-15 17:27 ` [PATCH v3 1/3] x86: Optimize memcmp SSE2 in memcmp.S Noah Goldstein
2022-04-15 17:28 ` [PATCH v3 2/3] x86: Remove memcmp-sse4.S Noah Goldstein
2022-04-15 17:32 ` H.J. Lu
2022-05-12 20:01 ` Sunil Pandey
2022-04-15 17:28 ` [PATCH v3 3/3] x86: Cleanup page cross code in memcmp-avx2-movbe.S Noah Goldstein
2022-04-15 17:33 ` H.J. Lu
2022-05-12 20:03 ` Sunil Pandey
2022-04-15 17:33 ` [PATCH v3 1/3] x86: Optimize memcmp SSE2 in memcmp.S H.J. Lu
2022-04-15 18:44 ` Noah Goldstein
2022-04-19 20:30 ` Joseph Myers
2022-04-19 20:53 ` Noah Goldstein
2022-04-19 22:56 ` Noah Goldstein [this message]
2022-04-20 1:19 ` Noah Goldstein
2022-05-12 19:59 ` Sunil Pandey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFUsyfLOTir+QsJOnhmQiU1n7jw4NP8=TrAecgMbww5HEFG=-g@mail.gmail.com' \
--to=goldstein.w.n@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).