From: Arjun Shankar <arjun@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 1/2] nptl: Remove unused members from struct pthread
Date: Tue, 28 Jun 2022 19:26:17 +0200 [thread overview]
Message-ID: <CAG_osabi7t63VYh0Nt59uzY7L0mJHRjDNrjkvyN-4ry2FTk_Cg@mail.gmail.com> (raw)
In-Reply-To: <20220426180705.1274657-2-adhemerval.zanella@linaro.org>
Hi Adhemerval,
This looks good to me.
Reviewed-by: Arjun Shankar <arjun@redhat.com>
> It removes both pid_ununsed and cpuclock_offset_ununsed, saving about
> 12 bytes from struct pthread.
> ---
> nptl/descr.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/nptl/descr.h b/nptl/descr.h
> index bb46b5958e..b5852632e3 100644
> --- a/nptl/descr.h
> +++ b/nptl/descr.h
> @@ -172,9 +172,6 @@ struct pthread
> therefore stack) used' flag. */
> pid_t tid;
>
> - /* Ununsed. */
> - pid_t pid_ununsed;
> -
OK. This has been unused since c579f48edba (2016).
> /* List of robust mutexes the thread is holding. */
> #if __PTHREAD_MUTEX_HAVE_PREV
> void *robust_prev;
> @@ -342,10 +339,6 @@ struct pthread
> /* Lock for synchronizing setxid calls. */
> unsigned int setxid_futex;
>
> -#if HP_TIMING_INLINE
> - hp_timing_t cpuclock_offset_ununsed;
> -#endif
> -
OK. This has been unused since 38cc11daa43 (2019).
> /* If the thread waits to join another one the ID of the latter is
> stored here.
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-06-28 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 18:07 [PATCH 0/2] Optimize struct pthread size Adhemerval Zanella
2022-04-26 18:07 ` [PATCH 1/2] nptl: Remove unused members from struct pthread Adhemerval Zanella
2022-06-28 17:26 ` Arjun Shankar [this message]
2022-04-26 18:07 ` [PATCH 2/2] Refactor internal-signals.h Adhemerval Zanella
2022-06-28 17:16 ` Arjun Shankar
2022-06-29 19:32 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG_osabi7t63VYh0Nt59uzY7L0mJHRjDNrjkvyN-4ry2FTk_Cg@mail.gmail.com \
--to=arjun@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).